cc: Chromify DebugRectHistory

cc: Chromify DebugRectHistory

R=danakj@chromium.org
BUG=none


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188069

[danakj, 2013-03-14 02:14:38]

LGTM

https://codereview.chromium.org/12522005/diff/1/cc/debug_rect_history.cc
File cc/debug_rect_history.cc (right):

https://codereview.chromium.org/12522005/diff/1/cc/debug_rect_history.cc#newc...
cc/debug_rect_history.cc:85: for (unsigned layerIndex = 0; layerIndex <
layer_list.size();
layer_index

the script's bad with for loops :(

https://codereview.chromium.org/12522005/diff/1/cc/debug_rect_history.cc#newc...
cc/debug_rect_history.cc:85: for (unsigned layerIndex = 0; layerIndex <
layer_list.size();
1 statement per line?

https://codereview.chromium.org/12522005/diff/1/cc/debug_rect_history.cc#newc...
cc/debug_rect_history.cc:97: debug_rects_.push_back(
{}

https://codereview.chromium.org/12522005/diff/1/cc/debug_rect_history.cc#newc...
cc/debug_rect_history.cc:137: if (render_surface_layer->replica_layer())
{}

https://codereview.chromium.org/12522005/diff/1/cc/debug_rect_history.cc#newc...
cc/debug_rect_history.cc:148: for (size_t i = 0; i < occluding_rects.size();
++i) {
no {}

[enne (OOO), 2013-03-14 02:47:14]

Thanks for the ongoing thorough style reviews!

https://codereview.chromium.org/12522005/diff/1/cc/debug_rect_history.cc
File cc/debug_rect_history.cc (right):

https://codereview.chromium.org/12522005/diff/1/cc/debug_rect_history.cc#newc...
cc/debug_rect_history.cc:85: for (unsigned layerIndex = 0; layerIndex <
layer_list.size();
On 2013/03/14 02:14:38, danakj wrote:
> 1 statement per line?

Done.

https://codereview.chromium.org/12522005/diff/1/cc/debug_rect_history.cc#newc...
cc/debug_rect_history.cc:97: debug_rects_.push_back(
On 2013/03/14 02:14:38, danakj wrote:
> {}

Done.

https://codereview.chromium.org/12522005/diff/1/cc/debug_rect_history.cc#newc...
cc/debug_rect_history.cc:137: if (render_surface_layer->replica_layer())
On 2013/03/14 02:14:38, danakj wrote:
> {}

Done.

https://codereview.chromium.org/12522005/diff/1/cc/debug_rect_history.cc#newc...
cc/debug_rect_history.cc:148: for (size_t i = 0; i < occluding_rects.size();
++i) {
On 2013/03/14 02:14:38, danakj wrote:
> no {}

"In general, curly braces are not required for single-line statements, but they
are allowed if you like them."

Just sayin', but I'll remove this anyway.

[commit-bot: I haz the power, 2013-03-14 02:50:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/enne@chromium.org/12522005/4001

[commit-bot: I haz the power, 2013-03-14 04:41:18]

Retried try job too often on mac_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2013-03-14 04:58:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/enne@chromium.org/12522005/4001

[commit-bot: I haz the power, 2013-03-14 14:54:03]

Change committed as 188069