Lazily load extension API schemas

chrome/common/extensions/api/extension_api.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_COMMON_EXTENSIONS_API_EXTENSION_API_H_
 #define CHROME_COMMON_EXTENSIONS_API_EXTENSION_API_H_
 
 #include <map>
 #include <set>
 #include <string>
@@ skipping 53 matching lines @@
   void RegisterSchema(const std::string& api_name,
                       const base::StringPiece& source);
 
   void RegisterDependencyProvider(const std::string& name,
                                   FeatureProvider* provider);
 
   // Returns true if the specified API is available. |api_full_name| can be
   // either a namespace name (like "bookmarks") or a member name (like
   // "bookmarks.create"). Returns true if the feature and all of its
   // dependencies are available to the specified context.
-  bool IsAvailable(const std::string& api_full_name,
-                   const Extension* extension,
-                   Feature::Context context);
+  Feature::Availability IsAvailable(const std::string& api_full_name,
+                                    const Extension* extension,
+                                    Feature::Context context,
+                                    const GURL& url);
+
+  // Returns true if the API uses the feature system.
+  bool UsesFeatureSystem(const std::string& full_name);

[not at google - send to devlin, 2013/03/14 19:16:46]

looks like this can be moved back out of public:

[cduvall, 2013/03/21 22:27:55]

Done.

 
   // Returns true if |name| is a privileged API path. Privileged paths can only
   // be called from extension code which is running in its own designated
   // extension process. They cannot be called from extension code running in
   // content scripts, or other low-privileged contexts.
   bool IsPrivileged(const std::string& name);
 
   // Gets the schema for the extension API with namespace |full_name|.
   // Ownership remains with this object.
   const base::DictionaryValue* GetSchema(const std::string& full_name);
 
-  // Gets the APIs available to |context| given an |extension| and |url|. The
-  // extension or URL may not be relevant to all contexts, and may be left
+  // Check if an API is available to |context| given an |extension| and |url|.
+  // The extension or URL may not be relevant to all contexts, and may be left
   // NULL/empty.
-  std::set<std::string> GetAPIsForContext(
-      Feature::Context context, const Extension* extension, const GURL& url);
+  bool IsNonFeatureAvailable(const std::string& name,

[not at google - send to devlin, 2013/03/14 19:16:46]

First file I'm reading: this name confuses me.

Also can be moved out of public:

[cduvall, 2013/03/21 22:27:55]

renamed to IsNonFeatureAPIAvailable()

+                             Feature::Context context,
+                             const Extension* extension,
+                             const GURL& url);
 
   std::set<std::string> GetAllAPINames();
 
   // Gets a Feature object describing the API with the specified |full_name|.
   // This can be either an API namespace (like history, or
   // experimental.bookmarks), or it can be an individual function or event.
   virtual Feature* GetFeature(const std::string& full_name) OVERRIDE;
 
   // Splits a full name from the extension API into its API and child name
   // parts. Some examples:
   //
   // "bookmarks.create" -> ("bookmarks", "create")
   // "experimental.input.ui.cursorUp" -> ("experimental.input.ui", "cursorUp")
   // "storage.sync.set" -> ("storage", "sync.get")
   // "<unknown-api>.monkey" -> ("", "")
   //
   // The |child_name| parameter can be be NULL if you don't need that part.
   std::string GetAPINameFromFullName(const std::string& full_name,
                                      std::string* child_name);
 
   void InitDefaultConfiguration();
 
-  // Loads the schemas registered with RegisterSchema().
-  void LoadAllSchemas();
-
  private:
   friend struct DefaultSingletonTraits<ExtensionAPI>;
 
   // Loads a schema.
   void LoadSchema(const std::string& name, const base::StringPiece& schema);
 
   // Returns true if the function or event under |namespace_node| with
   // the specified |child_name| is privileged, or false otherwise. If the name
   // is not found, defaults to privileged.
   bool IsChildNamePrivileged(const base::DictionaryValue* namespace_node,
                              const std::string& child_name);
 
-  // Adds all APIs to |out| that |extension| has any permission (required or
-  // optional) to use.
+  // Checks if API |name| is allowed.
   // NOTE: This only works for non-feature-controlled APIs.
   // TODO(aa): Remove this when all APIs are converted to the feature system.
-  void GetAllowedAPIs(const Extension* extension, std::set<std::string>* out);
+  bool IsAPIAllowed(const std::string& name, const Extension* extension);
 
   // Gets a feature from any dependency provider.
   Feature* GetFeatureDependency(const std::string& dependency_name);
 
   // Adds dependent schemas to |out| as determined by the "dependencies"
   // property.
   // TODO(aa): Consider making public and adding tests.
   void ResolveDependencies(std::set<std::string>* out);
 
   // Adds any APIs listed in "dependencies" found in the schema for |api_name|
   // but not in |excluding| to |out|.
   void GetMissingDependencies(
       const std::string& api_name,
       const std::set<std::string>& excluding,
       std::set<std::string>* out);
 
-  // Removes all APIs from |apis| which are *entirely* privileged. This won't
-  // include APIs such as "storage" which is entirely unprivileged, nor
-  // "extension" which has unprivileged components.
-  void RemovePrivilegedAPIs(std::set<std::string>* apis);
-
-  // Adds an APIs that match |url| to |out|.
-  // NOTE: This only works for non-feature-controlled APIs.
-  // TODO(aa): Remove this when all APIs are converted to the feature system.
-  void GetAPIsMatchingURL(const GURL& url, std::set<std::string>* out);
+  // Checks if an API is *entirely* privileged. This won't include APIs such as
+  // "storage" which is entirely unprivileged, nor "extension" which has
+  // unprivileged components.
+  bool IsPrivilegedAPI(const std::string& name);
 
   // Map from each API that hasn't been loaded yet to the schema which defines
   // it. Note that there may be multiple APIs per schema.
   typedef std::map<std::string, base::StringPiece> UnloadedSchemaMap;
   UnloadedSchemaMap unloaded_schemas_;
 
   // Schemas for each namespace.
   typedef std::map<std::string, linked_ptr<const DictionaryValue> > SchemaMap;
   SchemaMap schemas_;
 
@@ skipping 13 matching lines @@
   // FeatureProviders used for resolving dependencies.
   typedef std::map<std::string, FeatureProvider*> FeatureProviderMap;
   FeatureProviderMap dependency_providers_;
 
   DISALLOW_COPY_AND_ASSIGN(ExtensionAPI);
 };
 
 }  // extensions
 
 #endif  // CHROME_COMMON_EXTENSIONS_API_EXTENSION_API_H_