Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1193)

Issue 1252143002: scheduler: Don't run multiple tasks per batch in a nested run loop (Closed)

Created:
5 years, 5 months ago by Sami
Modified:
5 years, 5 months ago
CC:
chromium-reviews, scheduler-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

scheduler: Don't run multiple tasks per batch in a nested run loop If the scheduler is in a nested run loop, it mustn't run multiple tasks per batch. This is because one of those tasks could be a call to RunLoop::Quit(), which means we have to yield control back to the message loop. Since we have no direct way of observing when Quit is called, just limit the number of tasks per batch to 1 in nested run loops. BUG=444764 Committed: https://crrev.com/418ebef4953dba6f31d7b16d9b4d1565c8b22a83 Cr-Commit-Position: refs/heads/master@{#340133}

Patch Set 1 #

Patch Set 2 : Rebased. #

Patch Set 3 : Build fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -0 lines) Patch
M components/scheduler/child/task_queue_manager.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M components/scheduler/child/task_queue_manager_unittest.cc View 1 2 2 chunks +32 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
Sami
5 years, 5 months ago (2015-07-23 16:37:49 UTC) #2
alex clarke (OOO till 29th)
lgtm
5 years, 5 months ago (2015-07-23 16:41:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1252143002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1252143002/20001
5 years, 5 months ago (2015-07-23 16:52:46 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/95542)
5 years, 5 months ago (2015-07-23 17:04:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1252143002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1252143002/40001
5 years, 5 months ago (2015-07-23 17:16:58 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/81986)
5 years, 5 months ago (2015-07-23 17:43:38 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1252143002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1252143002/40001
5 years, 5 months ago (2015-07-23 17:53:07 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/31442)
5 years, 5 months ago (2015-07-23 18:05:33 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1252143002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1252143002/40001
5 years, 5 months ago (2015-07-23 18:09:28 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 5 months ago (2015-07-23 19:08:47 UTC) #20
commit-bot: I haz the power
5 years, 5 months ago (2015-07-23 19:10:04 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/418ebef4953dba6f31d7b16d9b4d1565c8b22a83
Cr-Commit-Position: refs/heads/master@{#340133}

Powered by Google App Engine
This is Rietveld 408576698