SkFlags now follows proper dashing convention.

SkFlags now follows proper dashing convention.

Two dashes are used for flags with multiple characters, and one
dash is used for flags with single characters.

In GM, changed '-wp' to '-p' (the command to choose a directory
for writing SKPs) to fit with the convention.

In render_pictures and bench_pictures, changed the flag for
read and write path to have full names (which are consistent)
and use the old single character names as their shortcuts.

SkCommandLineFlags: Updated the documentation, and only allow
-h or --help for help (again, to match the convention).
Also enforce the single character limit for the short name, and
require the full name to be at least two characters.

Provide full names for skhello.

BUG=https://code.google.com/p/skia/issues/detail?id=1174

Committed: https://code.google.com/p/skia/source/detail?r=8582

[reed1, 2013-03-21 22:06:59]

lgtm

Suggestion about the macro name, for clarity, but just a suggestion.

https://codereview.chromium.org/12521019/diff/1/tools/flags/SkCommandLineFlags.h
File tools/flags/SkCommandLineFlags.h (right):

https://codereview.chromium.org/12521019/diff/1/tools/flags/SkCommandLineFlag...
tools/flags/SkCommandLineFlags.h:152: #define DEFINE_string2(name, shortName,
defaultValue, helpString)               \
Can we name this DEFINE_char or DEFINE_string1, to sort of match its intent?

[scroggo, 2013-03-22 17:52:31]

https://codereview.chromium.org/12521019/diff/1/tools/flags/SkCommandLineFlags.h
File tools/flags/SkCommandLineFlags.h (right):

https://codereview.chromium.org/12521019/diff/1/tools/flags/SkCommandLineFlag...
tools/flags/SkCommandLineFlags.h:152: #define DEFINE_string2(name, shortName,
defaultValue, helpString)               \
On 2013/03/21 22:06:59, reed1 wrote:
> Can we name this DEFINE_char or DEFINE_string1, to sort of match its intent?

I agree that the current name is bad... I'm thinking something along the lines
of

DEFINE_string_with_shortcut

(although that feels a little on the long side)

[reed1, 2013-03-22 18:00:04]

lgtm

DEFINE_shortcut_string?

[scroggo, 2013-03-22 18:11:23]

On 2013/03/22 18:00:04, reed1 wrote:
> lgtm
> 
> DEFINE_shortcut_string?

The macro defines both a name and its shortcut on the same line. I think
DEFINE_shortcut_string sounds like it only defines the shortcut.

[reed1, 2013-03-22 18:45:29]

On 2013/03/22 18:11:23, scroggo wrote:
> On 2013/03/22 18:00:04, reed1 wrote:
> > lgtm
> > 
> > DEFINE_shortcut_string?
> 
> The macro defines both a name and its shortcut on the same line. I think
> DEFINE_shortcut_string sounds like it only defines the shortcut.

Ooops, I misinterpreted what it did. n/m

[scroggo, 2013-04-09 21:25:57]

Committed patchset #1 manually as r8582 (presubmit successful).