Compile FastCloneShallowArrayStub using Crankshaft.

Compile FastCloneShallowArrayStub using Crankshaft.

R=danno@chromium.org

Committed: http://code.google.com/p/v8/source/detail?r=14143

[Michael Starzinger, 2013-03-13 14:29:46]

The architecture ports are not yet done, but I wanted to get a first round of
comments.

https://codereview.chromium.org/12521011/diff/7001/src/isolate.cc
File src/isolate.cc (right):

https://codereview.chromium.org/12521011/diff/7001/src/isolate.cc#newcode2168
src/isolate.cc:2168: // deserialized out of the snapshot without the graph
builder.
I haven't found a clean solution for that yet, need to keep thinking about it.

[Michael Starzinger, 2013-04-04 11:09:03]

Ping.

[danno, 2013-04-04 11:16:56]

lgtm with comments

https://codereview.chromium.org/12521011/diff/7001/src/hydrogen.cc
File src/hydrogen.cc (right):

https://codereview.chromium.org/12521011/diff/7001/src/hydrogen.cc#newcode1205
src/hydrogen.cc:1205: AddInstruction(new(zone) HLoadNamedField(boilerplate,
true, i));
You need to use BuildStoreMap for the map (skip the first kPointerSize)?

https://codereview.chromium.org/12521011/diff/7001/src/hydrogen.cc#newcode1254
src/hydrogen.cc:1254: for (int i = 0; i < length; i++) {
Can you use HGraphBuilder::BuildCopyElements here?

[Michael Starzinger, 2013-04-04 17:07:02]

Addressed comments. Will rebase and land.

https://codereview.chromium.org/12521011/diff/7001/src/hydrogen.cc
File src/hydrogen.cc (right):

https://codereview.chromium.org/12521011/diff/7001/src/hydrogen.cc#newcode1205
src/hydrogen.cc:1205: AddInstruction(new(zone) HLoadNamedField(boilerplate,
true, i));
On 2013/04/04 11:16:56, danno wrote:
> You need to use BuildStoreMap for the map (skip the first kPointerSize)?

Done.

https://codereview.chromium.org/12521011/diff/7001/src/hydrogen.cc#newcode1254
src/hydrogen.cc:1254: for (int i = 0; i < length; i++) {
On 2013/04/04 11:16:56, danno wrote:
> Can you use HGraphBuilder::BuildCopyElements here?

As discussed offline: Yes, nice idea. We should teach BuildCopyElements to do
the loop unfolding up to a certain boundary and then just use it here. I left a
TODO and will do this in a separate CL.

[Michael Starzinger, 2013-04-04 17:56:18]

Committed patchset #6 manually as r14143 (presubmit successful).