Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2354)

Unified Diff: breakpad/breakpad_handler.gypi

Issue 12521002: Start and stop crash reporting outside of the loader lock. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: unit test Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome_frame/buggy_bho_handling.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: breakpad/breakpad_handler.gypi
diff --git a/breakpad/breakpad_handler.gypi b/breakpad/breakpad_handler.gypi
index 4764f8d11abcacf0c0e8525ff6f474aecb84fdbd..540e87e32566178c73b1c565e93280ffc5b217b0 100644
--- a/breakpad/breakpad_handler.gypi
+++ b/breakpad/breakpad_handler.gypi
@@ -28,6 +28,10 @@
'include_dirs': [
'src',
],
+ 'defines': [
+ # Avoid the TerminateThread Application Verifier Failure.
+ 'BREAKPAD_NO_TERMINATE_THREAD',
+ ],
}],
],
},
@@ -47,28 +51,6 @@
'src',
],
},
- 'defines': [
- # Avoid the TerminateThread Application Verifier Failure.
- 'BREAKPAD_NO_TERMINATE_THREAD',
- ],
- },
- {
- # This alternate breakpad target builds a breakpad that is suitable
- # for use with a DLL. It explicitly does NOT define
- # BREAKPAD_NO_TERMINATE_THREAD as that define makes breakpad crash
- # when created and destroyed in DllMain.
- 'target_name': 'breakpad_handler_dll',
- 'type': 'static_library',
- 'variables': {
- 'breakpad_handler_target': 1,
- },
- # TODO(gregoryd): direct_dependent_settings should be shared with the
- # 64-bit target, but it doesn't work due to a bug in gyp
- 'direct_dependent_settings': {
- 'include_dirs': [
- 'src',
- ],
- },
},
],
}],
@@ -87,10 +69,6 @@
'src',
],
},
- 'defines': [
- # Avoid the TerminateThread Application Verifier Failure.
- 'BREAKPAD_NO_TERMINATE_THREAD',
- ],
'configurations': {
'Common_Base': {
'msvs_target_platform': 'x64',
« no previous file with comments | « no previous file | chrome_frame/buggy_bho_handling.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698