components/content_settings/core/browser/content_settings_pref.h - Issue 1252073002: Move pref names and default value into WebsiteSettingsInfo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/content_settings/core/browser/content_settings_pref.h

Issue 1252073002: Move pref names and default value into WebsiteSettingsInfo (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@website-settings-registry-simple

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/content_settings/core/browser/content_settings_default_provider.cc ('k') | components/content_settings/core/browser/content_settings_pref.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/content_settings/core/browser/content_settings_pref.h

diff --git a/components/content_settings/core/browser/content_settings_pref.h b/components/content_settings/core/browser/content_settings_pref.h

index 2dd554b3f3f6aece45aab764c490ae47df6f7a30..5b9e5bb3e9d32bb73fbdafb870bda7d5fb569309 100644

--- a/components/content_settings/core/browser/content_settings_pref.h

+++ b/components/content_settings/core/browser/content_settings_pref.h

@@ -43,7 +43,7 @@ class ContentSettingsPref {

ContentSettingsPref(ContentSettingsType content_type,

PrefService* prefs,

PrefChangeRegistrar* registrar,

- const char* pref_name,

+ const std::string& pref_name,

bool incognito,

NotifyObserversCallback notify_callback);

~ContentSettingsPref();

@@ -110,7 +110,7 @@ class ContentSettingsPref {

PrefChangeRegistrar* registrar_;

// Name of the dictionary preference managed by this class.

- const char* pref_name_;

+ const std::string& pref_name_;

bool is_incognito_;