Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1251983005: Flag to disable SMIL support (Closed)

Created:
5 years, 5 months ago by Eric Willigers
Modified:
5 years, 3 months ago
Reviewers:
pdr.
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, Inactive, krit, f(malita), fs, gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans, vivekg_samsung, vivekg
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Flag to disable SMIL support Authors can use the command line flag --disable-blink-features=smil to disable SMIL functionality. blink-dev discussion https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/5o0yiO440LM/59rZqirUQNwJ BUG=498081 Committed: https://crrev.com/e1ddf6ccc2e25dd02b7e97cc861c8a87fb6eca47 git-svn-id: svn://svn.chromium.org/blink/trunk@199496 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Patch Set 2 : animateTransform #

Total comments: 1

Patch Set 3 : smil not sMIL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -20 lines) Patch
M LayoutTests/VirtualTestSuites View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
A LayoutTests/virtual/without-smil/svg/animations/exposed/README.txt View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A LayoutTests/virtual/without-smil/svg/animations/exposed/effect.html View 1 1 chunk +47 lines, -0 lines 0 comments Download
A LayoutTests/virtual/without-smil/svg/animations/exposed/effect-expected.txt View 1 1 chunk +5 lines, -0 lines 0 comments Download
A LayoutTests/virtual/without-smil/svg/animations/exposed/interface.html View 1 chunk +44 lines, -0 lines 0 comments Download
A LayoutTests/virtual/without-smil/svg/animations/exposed/interface-expected.txt View 1 chunk +20 lines, -0 lines 0 comments Download
M Source/core/svg/SVGAnimationElement.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/svg/SVGAnimationElement.idl View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/svg/SVGDiscardElement.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/svg/SVGDiscardElement.idl View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/svg/SVGDocumentExtensions.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGMPathElement.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/svg/SVGMPathElement.idl View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/svg/SVGSVGElement.cpp View 1 2 2 chunks +14 lines, -7 lines 0 comments Download
M Source/core/svg/SVGSVGElement.idl View 1 2 1 chunk +7 lines, -5 lines 0 comments Download
M Source/core/svg/SVGTagNames.in View 1 2 2 chunks +7 lines, -7 lines 0 comments Download
M Source/platform/RuntimeEnabledFeatures.in View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Eric Willigers
5 years, 5 months ago (2015-07-23 09:57:10 UTC) #2
pdr.
The sMILEnabled camel casing looks a little ugly. What do you think of making this ...
5 years, 5 months ago (2015-07-23 22:16:02 UTC) #3
Eric Willigers
On 2015/07/23 22:16:02, pdr wrote: > The sMILEnabled camel casing looks a little ugly. What ...
5 years, 5 months ago (2015-07-24 01:21:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1251983005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1251983005/40001
5 years, 5 months ago (2015-07-24 03:54:57 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/38384)
5 years, 5 months ago (2015-07-24 04:10:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1251983005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1251983005/40001
5 years, 4 months ago (2015-07-27 06:42:25 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://src.chromium.org/viewvc/blink?view=rev&revision=199496
5 years, 4 months ago (2015-07-27 07:51:03 UTC) #12
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 11:48:03 UTC) #13
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/e1ddf6ccc2e25dd02b7e97cc861c8a87fb6eca47

Powered by Google App Engine
This is Rietveld 408576698