drive: Some cleanup for ChangeListLoader

drive: Some cleanup for ChangeListLoader

- Remove UpdateMetadataParams which is not needed
- Remove the callback parameter from LoadRootFeedParams
- Rename OnGetResourceList to LoadFromServerAfterGetResourceList
- Introduce LoadChangeListFromServer()

BUG=178348
TEST=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188280

[kinaba, 2013-03-15 04:29:45]

The changes looks good, but can I ask one more additional rename?

I feel it better to rename LoadFromServer (and LoadFromServerAfterXXX or
XXXAfterLoadFromServer)
to something else, e.g., FetchResourceListFromServer.

Other occurrences of the term "Load" now mean "update the
resource metadata",
while the LoadFromServer family is a side-effect free,
"just fetching" methods.

CCing hidehiko@ who was also trying to remove UpdateMetadataParams
in a CL on hold: https://codereview.chromium.org/12516009/.

[satorux1, 2013-03-15 05:26:13]

On 2013/03/15 04:29:45, kinaba wrote:
> The changes looks good, but can I ask one more additional rename?
> 
> I feel it better to rename LoadFromServer (and LoadFromServerAfterXXX or
> XXXAfterLoadFromServer)
> to something else, e.g., FetchResourceListFromServer.

Yes. I agree. There are many things I want to rename in the code, but for now,
I'd minimize changes, and create a separate cleanup patch for global renames.


> Other occurrences of the term "Load" now mean "update the
> resource metadata",
> while the LoadFromServer family is a side-effect free,
> "just fetching" methods.
> 
> CCing hidehiko@ who was also trying to remove UpdateMetadataParams
> in a CL on hold: https://codereview.chromium.org/12516009/.

[kinaba, 2013-03-15 05:27:31]

ok, lgtm for the current patch.

[satorux1, 2013-03-15 07:18:43]

Committed patchset #3 manually as r188280 (presubmit successful).