Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4401)

Unified Diff: cc/tile_manager.h

Issue 12519006: cc:: Add RenderingStatsInstrumentation to manage collection of RenderingStats (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Early out in methods, pass raw pointers, updated tests Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/tile_manager.h
diff --git a/cc/tile_manager.h b/cc/tile_manager.h
index dd7e90b975aaed4ef32668592db0fc2806c18339..118b0e11aa4ec44b4ecb2ef42bba97fbe76b9f45 100644
--- a/cc/tile_manager.h
+++ b/cc/tile_manager.h
@@ -15,7 +15,7 @@
#include "base/values.h"
#include "cc/memory_history.h"
#include "cc/picture_pile_impl.h"
-#include "cc/rendering_stats.h"
+#include "cc/rendering_stats_recorder.h"
#include "cc/resource_pool.h"
#include "cc/tile_priority.h"
#include "cc/worker_pool.h"
@@ -106,6 +106,7 @@ class CC_EXPORT TileManager : public WorkerPoolClient {
TileManager(TileManagerClient* client,
ResourceProvider *resource_provider,
size_t num_raster_threads,
+ RenderingStatsRecorder* rendering_stats_recorder,
bool use_cheapess_estimator,
bool use_color_estimator,
bool prediction_benchmarking);
@@ -126,8 +127,6 @@ class CC_EXPORT TileManager : public WorkerPoolClient {
void GetMemoryStats(size_t* memoryRequiredBytes,
size_t* memoryNiceToHaveBytes,
size_t* memoryUsedBytes) const;
- void SetRecordRenderingStats(bool record_rendering_stats);
- void GetRenderingStats(RenderingStats* stats);
bool HasPendingWorkScheduled(WhichTree tree) const;
const MemoryHistory::Entry& memory_stats_from_last_assign() const {
@@ -193,14 +192,16 @@ class CC_EXPORT TileManager : public WorkerPoolClient {
WhichTree tree);
scoped_ptr<Value> GetMemoryRequirementsAsValue() const;
- static void RunRasterTask(uint8* buffer,
- const gfx::Rect& rect,
- float contents_scale,
- const RasterTaskMetadata& metadata,
- PicturePileImpl* picture_pile,
- RenderingStats* stats);
- static void RunImageDecodeTask(skia::LazyPixelRef* pixel_ref,
- RenderingStats* stats);
+ static void RunRasterTask(
+ uint8* buffer,
+ const gfx::Rect& rect,
+ float contents_scale,
+ const RasterTaskMetadata& metadata,
+ RenderingStatsRecorder* stats_recorder,
+ PicturePileImpl* picture_pile);
+ static void RunImageDecodeTask(
+ skia::LazyPixelRef* pixel_ref,
+ RenderingStatsRecorder* stats_recorder);
static void RecordCheapnessPredictorResults(bool is_predicted_cheap,
bool is_actually_cheap);
@@ -239,8 +240,7 @@ class CC_EXPORT TileManager : public WorkerPoolClient {
bool ever_exceeded_memory_budget_;
MemoryHistory::Entry memory_stats_from_last_assign_;
- bool record_rendering_stats_;
- RenderingStats rendering_stats_;
+ RenderingStatsRecorder* rendering_stats_recorder_;
bool use_cheapness_estimator_;
bool use_color_estimator_;
« cc/rendering_stats_recorder.cc ('K') | « cc/thread_proxy.cc ('k') | cc/tile_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698