Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issue 125183005: linux_aura: Reenable parallel_jobs_ (Closed)

Created:
6 years, 11 months ago by Elliot Glaysher
Modified:
6 years, 11 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

linux_aura: Reenable parallel_jobs_. In r239536 and r239680, I disabled all parallelization of unit test jobs on linux_aura, because using the clipboard used a desktop wide piece of X11 state, and running the tests in parallel meant that tests which were using the clipboard would steal the clipboard from other tests The "actual" "problem" seems to have been "fixed." These tests appear to be flakily failing in the same way in the GTK port, but are retried. On lniux_aura, the test harness wasn't rerunning the tests and was just marking them as failed. Now it's rerunning them, and they pass since flaky tests are rerun one at a time. This should still be a net win speed wise, since things fail flakily about one in four times, and even that one flaky run still runs twice as fast as the current runs. BUG=239536 R=kbr@chromium.org, phajdan.jr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243674

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
M base/test/launcher/test_launcher.cc View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Elliot Glaysher
Yay. It's "fixed".
6 years, 11 months ago (2014-01-07 21:49:12 UTC) #1
Ken Russell (switch to Gerrit)
LGTM This is great. The try job failures look unrelated, yes?
6 years, 11 months ago (2014-01-07 21:53:36 UTC) #2
Paweł Hajdan Jr.
LGTM
6 years, 11 months ago (2014-01-08 13:50:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/125183005/1
6 years, 11 months ago (2014-01-08 19:03:43 UTC) #4
Elliot Glaysher
6 years, 11 months ago (2014-01-08 22:25:17 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r243674 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698