Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(874)

Unified Diff: net/quic/quic_sent_packet_manager.cc

Issue 125183004: Fix a bug in QuicSentPacketManager::ClearPreviousRetransmissions where (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/quic/quic_sent_packet_manager_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_sent_packet_manager.cc
diff --git a/net/quic/quic_sent_packet_manager.cc b/net/quic/quic_sent_packet_manager.cc
index c7a5663f0eea7cddbe7b3acfd63cb5102c5f8339..65c0254434c4e93e0e6eb2a9a726c2e68a4a2a31 100644
--- a/net/quic/quic_sent_packet_manager.cc
+++ b/net/quic/quic_sent_packet_manager.cc
@@ -255,6 +255,13 @@ void QuicSentPacketManager::ClearPreviousRetransmissions(size_t num_to_clear) {
SequenceNumberSet* previous_transmissions =
it->second.previous_transmissions;
if (previous_transmissions == NULL) {
+ if (it->second.retransmittable_frames == NULL) {
+ // This is a current transmission, but a previous transmission has
+ // been acked, so it's safe to remove.
+ it = MarkPacketHandled(sequence_number, NOT_RECEIVED_BY_PEER);
+ --num_to_clear;
+ continue;
+ }
break;
}
QuicPacketSequenceNumber newest_transmission =
« no previous file with comments | « no previous file | net/quic/quic_sent_packet_manager_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698