Issue 125183004: Fix a bug in QuicSentPacketManager::ClearPreviousRetransmissions where

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 125183004: Fix a bug in QuicSentPacketManager::ClearPreviousRetransmissions where (Closed)

Created:
6 years, 11 months ago by ramant (doing other things)

Modified:
6 years, 11 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix a bug in QuicSentPacketManager::ClearPreviousRetransmissions where the high water mark is not raised past the current transmission of a packet whose previous packet has been ACKed. This bug was first observer in jri's lab experiments. Fix QUIC bug related to ACKs of previous transmission of packets. Merge internal change: 58760014 R=rch@chromium.org

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -0 lines)			Patch
	M	net/quic/quic_sent_packet_manager.cc	View		1 chunk	+7 lines, -0 lines	0 comments	Download
	M	net/quic/quic_sent_packet_manager_test.cc	View		1 chunk	+41 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ramant (doing other things)

Hi Ryan, Please don't review this CL yet (jumped the gun and published it for ...

6 years, 11 months ago (2014-01-06 19:27:39 UTC) #2

ramant (doing other things)

Updated the wrong CL. Please ignore the above comment. This CL is ok. EndToEndTest CL ...

6 years, 11 months ago (2014-01-06 19:43:29 UTC) #3

lgtm

Expand Messages | Collapse Messages