Issue 125183003: Correctly handle NACK-based "retransmission" of packets which no longer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 125183003: Correctly handle NACK-based "retransmission" of packets which no longer (Closed)

Created:
6 years, 11 months ago by ramant (doing other things)

Modified:
6 years, 11 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Correctly handle NACK-based "retransmission" of packets which no longer have retransmittable data associated with this. These can be the result of TLP retransmission or a current transmission of a packet whose previous transmission have been acked. Fix QUIC bug related to ACKs of previous transmission of packets. Merge internal change: 58758718 R=rch@chromium.org

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+119 lines, -4 lines)			Patch
M	net/quic/quic_sent_packet_manager.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	net/quic/quic_sent_packet_manager.cc	View	5 chunks	+38 lines, -4 lines	0 comments	Download
M	net/quic/quic_sent_packet_manager_test.cc	View	2 chunks	+78 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages