Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 1251823005: cc: Make DisplayScheduler aware of resize and add tracing. (Closed)

Created:
5 years, 5 months ago by brianderson
Modified:
5 years, 5 months ago
Reviewers:
jbauman, mithro-old
CC:
chromium-reviews, cc-bugs_chromium.org, sunnyps
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Make DisplayScheduler aware of resize and add tracing. Tracing makes it easier to see what's going on during resize. DisplayScheduler will now wait for a new root surface or damage on the existing root surface after a resize event before triggering its deadline. BUG=506300 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/abad13419002bc51bedb647bb89dac3838323996 Cr-Commit-Position: refs/heads/master@{#340225}

Patch Set 1 #

Patch Set 2 : fix tests; small logic changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -49 lines) Patch
M cc/surfaces/display.cc View 7 chunks +31 lines, -10 lines 0 comments Download
M cc/surfaces/display_scheduler.h View 1 2 chunks +3 lines, -2 lines 0 comments Download
M cc/surfaces/display_scheduler.cc View 1 6 chunks +22 lines, -16 lines 0 comments Download
M cc/surfaces/display_scheduler_unittest.cc View 1 3 chunks +67 lines, -5 lines 0 comments Download
M cc/surfaces/display_unittest.cc View 1 10 chunks +29 lines, -15 lines 0 comments Download
M cc/surfaces/surface_factory.cc View 2 chunks +5 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (5 generated)
brianderson
Would like to get these trace events in so it's more clear what's happening during ...
5 years, 5 months ago (2015-07-23 00:10:56 UTC) #2
jbauman
lgtm
5 years, 5 months ago (2015-07-23 00:14:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1251823005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1251823005/20001
5 years, 5 months ago (2015-07-23 21:45:25 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/47995)
5 years, 5 months ago (2015-07-23 22:06:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1251823005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1251823005/20001
5 years, 5 months ago (2015-07-23 22:27:10 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-24 05:11:30 UTC) #11
commit-bot: I haz the power
5 years, 5 months ago (2015-07-24 05:12:08 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/abad13419002bc51bedb647bb89dac3838323996
Cr-Commit-Position: refs/heads/master@{#340225}

Powered by Google App Engine
This is Rietveld 408576698