Protocol / client plugin changes to support interactively asking for a PIN

remoting/client/plugin/chromoting_instance.h

Index: remoting/client/plugin/chromoting_instance.h
diff --git a/remoting/client/plugin/chromoting_instance.h b/remoting/client/plugin/chromoting_instance.h
index 9765f9688b5449bfa7d752524c18d663df1c7c5d..3994131471466758f72dfa71862eae766f5dbc1d 100644
--- a/remoting/client/plugin/chromoting_instance.h
+++ b/remoting/client/plugin/chromoting_instance.h
@@ -39,6 +39,7 @@
 #include "remoting/protocol/cursor_shape_stub.h"
 #include "remoting/protocol/input_event_tracker.h"
 #include "remoting/protocol/mouse_input_filter.h"
+#include "remoting/protocol/negotiating_authenticator.h"
 
 namespace base {
 class DictionaryValue;
@@ -133,6 +134,12 @@ class ChromotingInstance :
   void NotifyClientResolution(int width, int height, int x_dpi, int y_dpi);
   void PauseVideo(bool pause);
   void PauseAudio(bool pause);
+  void FetchSecretFromDialog(

[Sergey Ulanov, 2013/03/20 05:49:05]

this and the following method do not need to be public.

[rmsousa, 2013/03/20 20:17:16]

Actually none of the methods in this block do - they're all called from this
class's own message processing.

Regardless of that, FetchSecretFrom* still don't belong in this group, so I
moved them.

+      const protocol::SecretFetchedCallback& secret_fetched_callback);
+  static void FetchSecretFromString(

[Sergey Ulanov, 2013/03/20 05:49:05]

nit: static methods should be declared above non-static ones.

[rmsousa, 2013/03/20 20:17:16]

Done.

+      const std::string& shared_secret,
+      const protocol::SecretFetchedCallback& secret_fetched_callback);
+  void OnPinFetched(const std::string& pin);

[rmsousa, 2013/03/20 04:54:54]

OnPinFetched and use_async_pin_dialog_ below are specifically related to the PIN
dialog (and not any secret), so I kept the PIN nomenclature.

[Sergey Ulanov, 2013/03/20 05:49:05]

sgtm

[rmsousa, 2013/03/20 20:17:16]

Done.

 
   // Return statistics record by ChromotingClient.
   // If no connection is currently active then NULL will be returned.
@@ -210,6 +217,10 @@ class ChromotingInstance :
   // connection.
   scoped_refptr<PepperXmppProxy> xmpp_proxy_;
 
+  // PIN Fetcher.
+  bool use_async_pin_dialog_;
+  protocol::SecretFetchedCallback secret_fetched_callback_;
+
   base::WeakPtrFactory<ChromotingInstance> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(ChromotingInstance);