Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(727)

Unified Diff: runtime/vm/instructions_arm_test.cc

Issue 12518016: Decode ic data and arguments descriptor passed in calls on ARM. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/instructions_arm.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/instructions_arm_test.cc
===================================================================
--- runtime/vm/instructions_arm_test.cc (revision 19826)
+++ runtime/vm/instructions_arm_test.cc (working copy)
@@ -16,13 +16,16 @@
ASSEMBLER_TEST_GENERATE(Call, assembler) {
__ BranchLinkPatchable(&StubCode::InstanceFunctionLookupLabel());
- // Do not emit any code after the call above, since we decode backwards
- // starting from the return address, i.e. from the end of this code buffer.
+ __ Ret();
}
ASSEMBLER_TEST_RUN(Call, test) {
- CallPattern call(test->entry() + test->code().Size(), test->code());
+ // The return address, which must be the address of an instruction contained
+ // in the code, points to the Ret instruction above, i.e. one instruction
+ // before the end of the code buffer.
+ CallPattern call(test->entry() + test->code().Size() - Instr::kInstrSize,
+ test->code());
EXPECT_EQ(StubCode::InstanceFunctionLookupLabel().address(),
call.TargetAddress());
}
« no previous file with comments | « runtime/vm/instructions_arm.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698