Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Side by Side Diff: runtime/vm/code_patcher_arm.cc

Issue 12518016: Decode ic data and arguments descriptor passed in calls on ARM. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/assembler_arm.cc ('k') | runtime/vm/code_patcher_arm_test.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM.
6 #if defined(TARGET_ARCH_ARM) 6 #if defined(TARGET_ARCH_ARM)
7 7
8 #include "vm/code_patcher.h" 8 #include "vm/code_patcher.h"
9 9
10 #include "vm/instructions.h" 10 #include "vm/instructions.h"
(...skipping 15 matching lines...) Expand all
26 ASSERT(code.ContainsInstructionAt(return_address)); 26 ASSERT(code.ContainsInstructionAt(return_address));
27 CallPattern call(return_address, code); 27 CallPattern call(return_address, code);
28 call.SetTargetAddress(new_target); 28 call.SetTargetAddress(new_target);
29 } 29 }
30 30
31 31
32 void CodePatcher::PatchInstanceCallAt(uword return_address, 32 void CodePatcher::PatchInstanceCallAt(uword return_address,
33 const Code& code, 33 const Code& code,
34 uword new_target) { 34 uword new_target) {
35 ASSERT(code.ContainsInstructionAt(return_address)); 35 ASSERT(code.ContainsInstructionAt(return_address));
36 UNIMPLEMENTED(); 36 CallPattern call(return_address, code);
37 call.SetTargetAddress(new_target);
37 } 38 }
38 39
39 40
40 void CodePatcher::InsertCallAt(uword start, uword target) { 41 void CodePatcher::InsertCallAt(uword start, uword target) {
41 UNIMPLEMENTED(); 42 UNIMPLEMENTED();
42 } 43 }
43 44
44 45
45 uword CodePatcher::GetInstanceCallAt(uword return_address, 46 uword CodePatcher::GetInstanceCallAt(uword return_address,
46 const Code& code, 47 const Code& code,
47 ICData* ic_data, 48 ICData* ic_data,
48 Array* arguments_descriptor) { 49 Array* arguments_descriptor) {
49 ASSERT(code.ContainsInstructionAt(return_address)); 50 ASSERT(code.ContainsInstructionAt(return_address));
50 UNIMPLEMENTED(); 51 CallPattern call(return_address, code);
51 return 0; 52 if (ic_data != NULL) {
53 *ic_data = call.IcData();
54 }
55 if (arguments_descriptor != NULL) {
56 *arguments_descriptor = call.ArgumentsDescriptor();
57 }
58 return call.TargetAddress();
52 } 59 }
53 60
54 61
55 intptr_t CodePatcher::InstanceCallSizeInBytes() { 62 intptr_t CodePatcher::InstanceCallSizeInBytes() {
56 UNIMPLEMENTED(); 63 // The instance call instruction sequence has a variable size on ARM.
64 UNREACHABLE();
57 return 0; 65 return 0;
58 } 66 }
59 67
60 } // namespace dart 68 } // namespace dart
61 69
62 #endif // defined TARGET_ARCH_ARM 70 #endif // defined TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « runtime/vm/assembler_arm.cc ('k') | runtime/vm/code_patcher_arm_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698