Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Issue 1251723003: Revert of Re-land: Reimplement automation API on top of C++-backed AXTree. (Closed)

Created:
5 years, 5 months ago by Alexei Svitkine (slow)
Modified:
5 years, 5 months ago
CC:
aboxhall+watch_chromium.org, arv+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, extensions-reviews_chromium.org, je_julie, kalyank, nektar+watch_chromium.org, oshima+watch_chromium.org, plundblad+watch_chromium.org, sadrul, stevenjb+watch_chromium.org, yuzo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Re-land: Reimplement automation API on top of C++-backed AXTree. (patchset #6 id:100001 of https://codereview.chromium.org/1231603009/) Reason for revert: Top crasher in today's canary - 74% of browser crashes. Reverting per stability sheriff guidelines (go/stability-sheriff). Original issue's description: > Re-land: Reimplement automation API on top of C++-backed AXTree. > > Original review: https://codereview.chromium.org/1155183006 > Landed in: r335183 > Reverted in: r335343 (bug 502311) > > BUG=495323, 502311 > > Committed: https://crrev.com/1777fbdbd234ddc8e19d4ba3a42cfd3234b8a158 > Cr-Commit-Position: refs/heads/master@{#339929} TBR=dcheng@chromium.org,aboxhall@chromium.org,dtseng@chromium.org,kalman@chromium.org,dmazzoni@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=495323, 502311 Committed: https://crrev.com/3cd234a649e3922895a6bb2e4ec786032034bb97 Cr-Commit-Position: refs/heads/master@{#340091}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2397 lines, -1795 lines) Patch
M chrome/browser/extensions/api/automation/automation_apitest.cc View 4 chunks +334 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/automation_internal/automation_event_router.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/automation_internal/automation_internal_api.cc View 7 chunks +9 lines, -58 lines 0 comments Download
A chrome/browser/extensions/api/automation_internal/automation_util.h View 1 chunk +41 lines, -0 lines 0 comments Download
A chrome/browser/extensions/api/automation_internal/automation_util.cc View 1 chunk +213 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/aura/accessibility/automation_manager_aura.cc View 4 chunks +28 lines, -24 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/automation.idl View 5 chunks +111 lines, -103 lines 0 comments Download
M chrome/common/extensions/api/automation_internal.idl View 3 chunks +41 lines, -3 lines 0 comments Download
M chrome/renderer/extensions/automation_internal_custom_bindings.h View 3 chunks +2 lines, -125 lines 0 comments Download
M chrome/renderer/extensions/automation_internal_custom_bindings.cc View 9 chunks +25 lines, -486 lines 0 comments Download
M chrome/renderer/resources/extensions/automation/automation_node.js View 12 chunks +647 lines, -457 lines 0 comments Download
M chrome/renderer/resources/extensions/automation_custom_bindings.js View 10 chunks +19 lines, -71 lines 0 comments Download
D chrome/test/data/extensions/api_test/automation/sites/attributes.html View 1 chunk +0 lines, -73 lines 0 comments Download
A chrome/test/data/extensions/api_test/automation/sites/mixins.html View 1 chunk +72 lines, -0 lines 0 comments Download
D chrome/test/data/extensions/api_test/automation/tests/tabs/attributes.html View 1 chunk +0 lines, -7 lines 0 comments Download
D chrome/test/data/extensions/api_test/automation/tests/tabs/attributes.js View 1 chunk +0 lines, -241 lines 0 comments Download
A chrome/test/data/extensions/api_test/automation/tests/tabs/mixins.html View 1 chunk +7 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/automation/tests/tabs/mixins.js View 1 chunk +246 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/automation/tests/tabs/sanity_check.js View 1 chunk +19 lines, -18 lines 0 comments Download
M chrome/test/data/extensions/api_test/automation/tests/tabs/tree_change.js View 1 chunk +1 line, -1 line 0 comments Download
A chrome/test/data/extensions/api_test/automation/tests/unit/manifest.json View 1 chunk +8 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/automation/tests/unit/test.js View 1 chunk +508 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/automation/tests/unit/unit.html View 1 chunk +6 lines, -0 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_manager_unittest.cc View 12 chunks +17 lines, -70 lines 0 comments Download
M extensions/renderer/logging_native_handler.h View 1 chunk +3 lines, -0 lines 0 comments Download
M extensions/renderer/logging_native_handler.cc View 2 chunks +27 lines, -3 lines 0 comments Download
M extensions/renderer/script_context.h View 1 chunk +0 lines, -3 lines 0 comments Download
M extensions/renderer/script_context.cc View 2 chunks +0 lines, -30 lines 0 comments Download
M ui/accessibility/ax_tree.cc View 2 chunks +4 lines, -7 lines 0 comments Download
M ui/accessibility/ax_tree_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Alexei Svitkine (slow)
Created Revert of Re-land: Reimplement automation API on top of C++-backed AXTree.
5 years, 5 months ago (2015-07-23 14:36:16 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1251723003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1251723003/1
5 years, 5 months ago (2015-07-23 14:36:29 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-23 14:38:00 UTC) #3
commit-bot: I haz the power
5 years, 5 months ago (2015-07-23 14:38:44 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3cd234a649e3922895a6bb2e4ec786032034bb97
Cr-Commit-Position: refs/heads/master@{#340091}

Powered by Google App Engine
This is Rietveld 408576698