sdk/lib/_internal/compiler/implementation/js_backend/namer.dart - Issue 12517012: Revert "Revert "Use interceptor convention for methods declared on native classes.""

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/js_backend/namer.dart

Issue 12517012: Revert "Revert "Use interceptor convention for methods declared on native classes."" (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart ('k') | sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/js_backend/namer.dart

diff --git a/sdk/lib/_internal/compiler/implementation/js_backend/namer.dart b/sdk/lib/_internal/compiler/implementation/js_backend/namer.dart

index cd1d7c01d8eb21ed87bd59808388b9bf3de62cc5..1d52f469ec7bd065f07fe41756bc24db5948c18c 100644

--- a/sdk/lib/_internal/compiler/implementation/js_backend/namer.dart

+++ b/sdk/lib/_internal/compiler/implementation/js_backend/namer.dart

@@ -552,9 +552,16 @@ class Namer implements ClosureNamer {

if (cls == backend.jsBoolClass) return "b";

return cls.name.slowToString();

}

+ List<String> names = classes

+ .where((cls) => !cls.isNative())

+ .map(abbreviate)

+ .toList();

+ // There is one dispatch mechanism for all native classes.

+ if (classes.any((cls) => cls.isNative())) {

+ names.add("x");

+ }

// Sort the names of the classes after abbreviating them to ensure

// the suffix is stable and predictable for the suggested names.

- List<String> names = classes.map(abbreviate).toList();

names.sort();

return names.join();

}