Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4893)

Unified Diff: chrome/renderer/resources/extensions/tabs_custom_bindings.js

Issue 12517011: Added activity logging for ext APIs with custom bindings (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Modified setHandleRequest to avoid double logging Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/resources/extensions/tabs_custom_bindings.js
diff --git a/chrome/renderer/resources/extensions/tabs_custom_bindings.js b/chrome/renderer/resources/extensions/tabs_custom_bindings.js
index 0d7c405ef2928f39aef27023837649daba5c9b0d..98fecb98795752ae33a8e9524b5be2aeb31b8a7e 100644
--- a/chrome/renderer/resources/extensions/tabs_custom_bindings.js
+++ b/chrome/renderer/resources/extensions/tabs_custom_bindings.js
@@ -23,7 +23,7 @@ binding.registerCustomHook(function(bindingsAPI, extensionId) {
}
var portId = OpenChannelToTab(tabId, extensionId, name);
return chromeHidden.Port.createPort(portId, name);
- });
+ }, false);
apiFunctions.setHandleRequest('sendRequest',
function(tabId, request, responseCallback) {
@@ -31,13 +31,13 @@ binding.registerCustomHook(function(bindingsAPI, extensionId) {
throw new Error(sendRequestIsDisabled);
var port = tabs.connect(tabId, {name: chromeHidden.kRequestChannel});
chromeHidden.Port.sendMessageImpl(port, request, responseCallback);
- });
+ }, false);
apiFunctions.setHandleRequest('sendMessage',
function(tabId, message, responseCallback) {
var port = tabs.connect(tabId, {name: chromeHidden.kMessageChannel});
chromeHidden.Port.sendMessageImpl(port, message, responseCallback);
- });
+ }, false);
});
exports.binding = binding.generate();

Powered by Google App Engine
This is Rietveld 408576698