Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3081)

Unified Diff: chrome/renderer/resources/extensions/send_request.js

Issue 12517011: Added activity logging for ext APIs with custom bindings (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Renamed some variables Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/resources/extensions/send_request.js
diff --git a/chrome/renderer/resources/extensions/send_request.js b/chrome/renderer/resources/extensions/send_request.js
index a805578ef41ce49b3b7148b7a3e4e3b05d2a4591..a31d641e522b8f3986ca30fe3745d9cdd8ceb5b3 100644
--- a/chrome/renderer/resources/extensions/send_request.js
+++ b/chrome/renderer/resources/extensions/send_request.js
@@ -13,6 +13,10 @@ var validate = require('schemaUtils').validate;
// All outstanding requests from sendRequest().
var requests = {};
+// Used to prevent double Activity Logging for API calls that use both custom
+// bindings and ExtensionFunctions (via sendRequest).
+var calledSendRequest = false;
+
// Callback handling.
chromeHidden.handleResponse = function(requestId, name,
success, responseList, error) {
@@ -103,6 +107,7 @@ function prepareRequest(args, argSchemas) {
// thread.
// - preserveNullInObjects: true if it is safe for null to be in objects.
function sendRequest(functionName, args, argSchemas, optArgs) {
+ calledSendRequest = true;
if (!optArgs)
optArgs = {};
var request = prepareRequest(args, argSchemas);
@@ -134,4 +139,14 @@ function sendRequest(functionName, args, argSchemas, optArgs) {
optArgs.preserveNullInObjects);
}
+function getCalledSendRequest() {
+ return calledSendRequest;
+}
+
+function clearCalledSendRequest() {
+ calledSendRequest = false;
+}
+
exports.sendRequest = sendRequest;
+exports.getCalledSendRequest = getCalledSendRequest;
+exports.clearCalledSendRequest = clearCalledSendRequest;

Powered by Google App Engine
This is Rietveld 408576698