Added activity logging for ext APIs with custom bindings

chrome/renderer/resources/extensions/schema_generated_bindings.js

Index: chrome/renderer/resources/extensions/schema_generated_bindings.js
diff --git a/chrome/renderer/resources/extensions/schema_generated_bindings.js b/chrome/renderer/resources/extensions/schema_generated_bindings.js
index 65d5cad57b2ddd836beb76b60bb2b3c799c1b35d..ff2e3e829eb837303cde317548a0a122b63d0622 100644
--- a/chrome/renderer/resources/extensions/schema_generated_bindings.js
+++ b/chrome/renderer/resources/extensions/schema_generated_bindings.js
@@ -15,6 +15,7 @@
   var utils = require('utils');
   var chromeHidden = requireNative('chrome_hidden').GetChromeHidden();
   var schemaUtils = require('schemaUtils');
+  var logActivity = requireNative('activityLogger').LogActivity;
 
   // The object to generate the bindings for "internal" APIs in, so that
   // extensions can't directly call them (without access to chromeHidden),
@@ -31,6 +32,7 @@
   function APIFunctions() {
     this._apiFunctions = {};
     this._unavailableApiFunctions = {};
+    this.extensionId = "unknown";
   }
   APIFunctions.prototype.register = function(apiName, apiFunction) {
     this._apiFunctions[apiName] = apiFunction;
@@ -51,7 +53,13 @@
   };
   APIFunctions.prototype.setHandleRequest =
       function(apiName, customizedFunction) {
-    return this._setHook(apiName, 'handleRequest', customizedFunction);
+    var ext_id = this.extensionId;
+    return this._setHook(apiName, 'handleRequest',
+      function() {
+        logActivity(ext_id, apiName,

[Matt Perry, 2013/03/14 20:32:31]

Unfortunately, some APIs that use setHandleRequest still use the
ExtensionFunction machinery too. This will double-count those. See for example
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/renderer/re...

Anything that calls sendRequest is using an ExtensionFunction.

I can think of a few ideas. From the hacky:
- Have sendRequest set a global variable, and only log if that var is not set.

to the slightly better but still ugly:
- Add a setHandleRequestLocally (or something) for APIs that don't call
sendRequest, and only log from there. There's no good way to enforce they don't
call sendRequest, though.

Do you have any ideas?

[felt, 2013/03/15 00:04:47]

Good catch.  OK, I did a version of the second one.  I added a boolean argument
to setHandleRequest. If the extra arg is false or missing, it logs; if it's
true, it doesn't log.  This has two properties:

(1) Someone who is copying code to use setHandleRequest will see the boolean. If
we made a new method like setHandleRequestDontLog, people might not see it.
(2) If I missed an invocation to setHandleRequest, or someone in the future
forgets the boolean, we don't start missing log entries; instead, the worst case
is that an event gets logged twice.


On 2013/03/14 20:32:31, Matt Perry wrote:

+            Array.prototype.slice.call(arguments));
+        return customizedFunction.apply(this, arguments);
+      });
   };
   APIFunctions.prototype.setUpdateArgumentsPostValidate =
       function(apiName, customizedFunction) {
@@ -257,6 +265,7 @@
 
       // Setup Functions.
       if (apiDef.functions) {
+        apiFunctions.extensionId = extensionId;
         apiDef.functions.forEach(function(functionDef) {
           if (functionDef.name in mod) {
             throw new Error('Function ' + functionDef.name +