Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Side by Side Diff: chrome/renderer/resources/extensions/page_action_custom_bindings.js

Issue 12517011: Added activity logging for ext APIs with custom bindings (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Modified setHandleRequest to avoid double logging Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Custom binding for the pageAction API. 5 // Custom binding for the pageAction API.
6 6
7 var binding = require('binding').Binding.create('pageAction'); 7 var binding = require('binding').Binding.create('pageAction');
8 8
9 var setIcon = require('setIcon').setIcon; 9 var setIcon = require('setIcon').setIcon;
10 10
11 binding.registerCustomHook(function(bindingsAPI) { 11 binding.registerCustomHook(function(bindingsAPI) {
12 var apiFunctions = bindingsAPI.apiFunctions; 12 var apiFunctions = bindingsAPI.apiFunctions;
13 13
14 apiFunctions.setHandleRequest('setIcon', function(details, callback) { 14 apiFunctions.setHandleRequest('setIcon', function(details, callback) {
15 setIcon(details, callback, this.name, this.definition.parameters, 15 setIcon(details, callback, this.name, this.definition.parameters,
16 'page action'); 16 'page action');
17 }); 17 }, false);
Matt Perry 2013/03/15 17:51:07 setIcon
18 }); 18 });
19 19
20 exports.binding = binding.generate(); 20 exports.binding = binding.generate();
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698