Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: chrome/renderer/resources/extensions/file_browser_handler_custom_bindings.js

Issue 12517011: Added activity logging for ext APIs with custom bindings (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Modified setHandleRequest to avoid double logging Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Custom binding for the fileBrowserHandler API. 5 // Custom binding for the fileBrowserHandler API.
6 6
7 var binding = require('binding').Binding.create('fileBrowserHandler'); 7 var binding = require('binding').Binding.create('fileBrowserHandler');
8 8
9 var fileBrowserNatives = requireNative('file_browser_handler'); 9 var fileBrowserNatives = requireNative('file_browser_handler');
10 var GetExternalFileEntry = fileBrowserNatives.GetExternalFileEntry; 10 var GetExternalFileEntry = fileBrowserNatives.GetExternalFileEntry;
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 result = { success: internalResult.success, entry: null }; 45 result = { success: internalResult.success, entry: null };
46 if (internalResult.success) 46 if (internalResult.success)
47 result.entry = GetExternalFileEntry(internalResult.entry); 47 result.entry = GetExternalFileEntry(internalResult.entry);
48 } 48 }
49 49
50 externalCallback(result); 50 externalCallback(result);
51 } 51 }
52 52
53 return fileBrowserHandlerInternal.selectFile( 53 return fileBrowserHandlerInternal.selectFile(
54 selectionParams, internalCallback.bind(null, callback)); 54 selectionParams, internalCallback.bind(null, callback));
55 }); 55 }, false);
Matt Perry 2013/03/15 17:51:07 selectFile uses sendRequest. (We have a handful of
56 }); 56 });
57 57
58 exports.binding = binding.generate(); 58 exports.binding = binding.generate();
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698