Added activity logging for ext APIs with custom bindings

chrome/renderer/resources/extensions/extension_custom_bindings.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Custom binding for the extension API.
 
 var binding = require('binding').Binding.create('extension');
 
 var extensionNatives = requireNative('extension');
 var forEach = require('utils').forEach;
@@ skipping 33 matching lines @@
     var type = 'ALL';
     if (properties) {
       if (properties.type != null) {
         type = properties.type;
       }
       if (properties.windowId != null) {
         windowId = properties.windowId;
       }
     }
     return GetExtensionViews(windowId, type) || null;
-  });
+  }, false);
 
   apiFunctions.setHandleRequest('getBackgroundPage', function() {
     return GetExtensionViews(-1, 'BACKGROUND')[0] || null;
-  });
+  }, false);
 
   apiFunctions.setHandleRequest('getExtensionTabs', function(windowId) {
     if (windowId == null)
       windowId = WINDOW_ID_NONE;
     return GetExtensionViews(windowId, 'TAB');
-  });
+  }, false);
 
   apiFunctions.setHandleRequest('getURL', function(path) {
     path = String(path);
     if (!path.length || path[0] != '/')
       path = '/' + path;
     return 'chrome-extension://' + extensionId + path;
-  });
+  }, false);
 
   // Alias several messaging deprecated APIs to their runtime counterparts.
   var mayNeedAlias = [
     // Types
     'Port',
     // Functions
     'connect', 'sendMessage', 'connectNative', 'sendNativeMessage',
     // Events
     'onConnect', 'onConnectExternal', 'onMessage', 'onMessageExternal'
   ];
   forEach(mayNeedAlias, function(i, alias) {
     // Checking existence isn't enough since some functions are disabled via
     // getters that throw exceptions. Assume that any getter is such a function.
     if (chrome.runtime.hasOwnProperty(alias) &&
         chrome.runtime.__lookupGetter__(alias) === undefined) {
       extension[alias] = chrome.runtime[alias];
     }
   });
 
   apiFunctions.setUpdateArgumentsPreValidate('sendRequest',
       sendMessageUpdateArguments.bind(null, 'sendRequest'));
 
   apiFunctions.setHandleRequest('sendRequest',
                                 function(targetId, request, responseCallback) {
     if (sendRequestIsDisabled)
       throw new Error(sendRequestIsDisabled);
     var port = chrome.runtime.connect(targetId || extensionId,
                                       {name: chromeHidden.kRequestChannel});
     chromeHidden.Port.sendMessageImpl(port, request, responseCallback);
-  });
+  }, false);

[Matt Perry, 2013/03/15 17:51:07]

This one is the messaging API - do you plan on logging that separately?

[felt, 2013/03/15 23:26:15]

FYI I have a separate CL pertaining to messaging that I haven't uploaded yet
(with special-case handling for callbacks + a cross-extension test).

On 2013/03/15 17:51:07, Matt Perry wrote:

 
   if (sendRequestIsDisabled) {
     extension.onRequest.addListener = function() {
       throw new Error(sendRequestIsDisabled);
     };
     if (contextType == 'BLESSED_EXTENSION') {
       extension.onRequestExternal.addListener = function() {
         throw new Error(sendRequestIsDisabled);
       };
     }
   }
 });
 
 exports.binding = binding.generate();