Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(998)

Unified Diff: cc/resources/resource_provider.h

Issue 1251693003: cc: Fix the format of GpuMemoryBuffer for SurfaceTexture (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move the targets to ResourceProvider and fix the nits Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/resources/resource_provider.h
diff --git a/cc/resources/resource_provider.h b/cc/resources/resource_provider.h
index d5b57127c205db172299d6cc7048e747779e56a8..53896b8a89437d96a825d33bc635d3c3f9716dca 100644
--- a/cc/resources/resource_provider.h
+++ b/cc/resources/resource_provider.h
@@ -85,7 +85,8 @@ class CC_EXPORT ResourceProvider {
int highp_threshold_min,
bool use_rgba_4444_texture_format,
size_t id_allocation_chunk_size,
- bool use_persistent_map_for_gpu_memory_buffers);
+ bool use_persistent_map_for_gpu_memory_buffers,
+ std::vector<unsigned> use_image_texture_targets);
reveman 2015/07/28 08:58:26 nit: const std::vector<unsigned>&
virtual ~ResourceProvider();
void DidLoseOutputSurface() { lost_output_surface_ = true; }
@@ -437,6 +438,8 @@ class CC_EXPORT ResourceProvider {
void ValidateResource(ResourceId id) const;
+ GLenum GetImageTextureTarget(ResourceFormat format);
+
protected:
ResourceProvider(OutputSurface* output_surface,
SharedBitmapManager* shared_bitmap_manager,
@@ -445,7 +448,8 @@ class CC_EXPORT ResourceProvider {
int highp_threshold_min,
bool use_rgba_4444_texture_format,
size_t id_allocation_chunk_size,
- bool use_persistent_map_for_gpu_memory_buffers);
+ bool use_persistent_map_for_gpu_memory_buffers,
+ std::vector<unsigned> use_image_texture_targets);
reveman 2015/07/28 08:58:26 nit: const std::vector<unsigned>&
void Initialize();
private:
@@ -601,6 +605,7 @@ class CC_EXPORT ResourceProvider {
bool use_sync_query_;
bool use_persistent_map_for_gpu_memory_buffers_;
+ std::vector<unsigned> use_image_texture_targets_;
// Fence used for CopyResource if CHROMIUM_sync_query is not supported.
scoped_refptr<SynchronousFence> synchronous_fence_;

Powered by Google App Engine
This is Rietveld 408576698