Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11531)

Unified Diff: content/renderer/render_thread_impl.cc

Issue 1251693003: cc: Fix the format of GpuMemoryBuffer for SurfaceTexture (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Change switches::kContentImageTextureTarget to a list of image texture targets Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_thread_impl.cc
diff --git a/content/renderer/render_thread_impl.cc b/content/renderer/render_thread_impl.cc
index 405645159f0bb2ea4767dcc764bf1b193bd12f66..4a427fc15e444ad26273658697758a88702ccb2d 100644
--- a/content/renderer/render_thread_impl.cc
+++ b/content/renderer/render_thread_impl.cc
@@ -417,6 +417,19 @@ void CreateEmbeddedWorkerSetup(
new EmbeddedWorkerSetupImpl(request.Pass());
}
+void StringToUintVector(const std::string& str, std::vector<uint>* vector) {
+ DCHECK(vector);
reveman 2015/07/27 17:07:15 This DCHECK seems overkill. Can you instead DCHECK
+ std::vector<std::string> pieces;
+ base::SplitString(str, ',', &pieces);
+ DCHECK(pieces.size() == gfx::GpuMemoryBuffer::FORMAT_LAST + 1);
reveman 2015/07/27 17:07:15 nit: use DCHECK_EQ
+ for (size_t i = 0; i < pieces.size(); ++i) {
+ uint number = 0;
+ bool succeed = base::StringToUint(pieces[i], &number);
+ DCHECK(succeed);
+ vector->push_back(number);
+ }
+}
+
} // namespace
class RasterWorkerPool : public base::SequencedTaskRunner,
@@ -765,9 +778,7 @@ void RenderThreadImpl::Init() {
std::string image_texture_target_string =
command_line.GetSwitchValueASCII(switches::kContentImageTextureTarget);
- bool parsed_image_texture_target = base::StringToUint(
- image_texture_target_string, &use_image_texture_target_);
- DCHECK(parsed_image_texture_target);
+ StringToUintVector(image_texture_target_string, &use_image_texture_targets_);
if (command_line.HasSwitch(switches::kDisableLCDText)) {
is_lcd_text_enabled_ = false;
@@ -1572,8 +1583,8 @@ bool RenderThreadImpl::IsElasticOverscrollEnabled() {
return is_elastic_overscroll_enabled_;
}
-uint32 RenderThreadImpl::GetImageTextureTarget() {
- return use_image_texture_target_;
+std::vector<uint> RenderThreadImpl::GetImageTextureTargets() {
+ return use_image_texture_targets_;
}
scoped_refptr<base::SingleThreadTaskRunner>

Powered by Google App Engine
This is Rietveld 408576698