Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Side by Side Diff: cc/resources/resource_pool.cc

Issue 1251693003: cc: Fix the format of GpuMemoryBuffer for SurfaceTexture (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move the targets to ResourceProvider and fix the nits Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/resources/resource_pool.h" 5 #include "cc/resources/resource_pool.h"
6 6
7 #include "cc/resources/resource_provider.h" 7 #include "cc/resources/resource_provider.h"
8 #include "cc/resources/scoped_resource.h" 8 #include "cc/resources/scoped_resource.h"
9 9
10 namespace cc { 10 namespace cc {
11 11
12 ResourcePool::ResourcePool(ResourceProvider* resource_provider)
13 : resource_provider_(resource_provider),
14 target_(0),
15 max_memory_usage_bytes_(0),
16 max_unused_memory_usage_bytes_(0),
17 max_resource_count_(0),
18 memory_usage_bytes_(0),
19 unused_memory_usage_bytes_(0),
20 resource_count_(0) {}
21
12 ResourcePool::ResourcePool(ResourceProvider* resource_provider, GLenum target) 22 ResourcePool::ResourcePool(ResourceProvider* resource_provider, GLenum target)
13 : resource_provider_(resource_provider), 23 : resource_provider_(resource_provider),
14 target_(target), 24 target_(target),
15 max_memory_usage_bytes_(0), 25 max_memory_usage_bytes_(0),
16 max_unused_memory_usage_bytes_(0), 26 max_unused_memory_usage_bytes_(0),
17 max_resource_count_(0), 27 max_resource_count_(0),
18 memory_usage_bytes_(0), 28 memory_usage_bytes_(0),
19 unused_memory_usage_bytes_(0), 29 unused_memory_usage_bytes_(0),
20 resource_count_(0) {} 30 resource_count_(0) {
31 DCHECK_NE(0u, target);
32 }
21 33
22 ResourcePool::~ResourcePool() { 34 ResourcePool::~ResourcePool() {
23 while (!busy_resources_.empty()) { 35 while (!busy_resources_.empty()) {
24 auto const& front = busy_resources_.front(); 36 auto const& front = busy_resources_.front();
25 DidFinishUsingResource(front.resource, front.content_id); 37 DidFinishUsingResource(front.resource, front.content_id);
26 busy_resources_.pop_front(); 38 busy_resources_.pop_front();
27 } 39 }
28 40
29 SetResourceUsageLimits(0, 0, 0); 41 SetResourceUsageLimits(0, 0, 0);
30 DCHECK_EQ(0u, unused_resources_.size()); 42 DCHECK_EQ(0u, unused_resources_.size());
(...skipping 16 matching lines...) Expand all
47 continue; 59 continue;
48 60
49 unused_resources_.erase(it); 61 unused_resources_.erase(it);
50 unused_memory_usage_bytes_ -= 62 unused_memory_usage_bytes_ -=
51 Resource::UncheckedMemorySizeBytes(size, format); 63 Resource::UncheckedMemorySizeBytes(size, format);
52 return make_scoped_ptr(resource); 64 return make_scoped_ptr(resource);
53 } 65 }
54 66
55 scoped_ptr<ScopedResource> resource = 67 scoped_ptr<ScopedResource> resource =
56 ScopedResource::Create(resource_provider_); 68 ScopedResource::Create(resource_provider_);
57 resource->AllocateManaged(size, target_, format); 69 GLenum target =
70 target_ ? target_ : resource_provider_->GetImageTextureTarget(format);
71 resource->AllocateManaged(size, target, format);
58 72
59 DCHECK(Resource::VerifySizeInBytes(resource->size(), resource->format())); 73 DCHECK(Resource::VerifySizeInBytes(resource->size(), resource->format()));
60 memory_usage_bytes_ += 74 memory_usage_bytes_ +=
61 Resource::UncheckedMemorySizeBytes(resource->size(), resource->format()); 75 Resource::UncheckedMemorySizeBytes(resource->size(), resource->format());
62 ++resource_count_; 76 ++resource_count_;
63 return resource.Pass(); 77 return resource.Pass();
64 } 78 }
65 79
66 scoped_ptr<ScopedResource> ResourcePool::TryAcquireResourceWithContentId( 80 scoped_ptr<ScopedResource> ResourcePool::TryAcquireResourceWithContentId(
67 uint64_t content_id) { 81 uint64_t content_id) {
(...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after
150 } 164 }
151 165
152 void ResourcePool::DidFinishUsingResource(ScopedResource* resource, 166 void ResourcePool::DidFinishUsingResource(ScopedResource* resource,
153 uint64_t content_id) { 167 uint64_t content_id) {
154 unused_memory_usage_bytes_ += 168 unused_memory_usage_bytes_ +=
155 Resource::UncheckedMemorySizeBytes(resource->size(), resource->format()); 169 Resource::UncheckedMemorySizeBytes(resource->size(), resource->format());
156 unused_resources_.push_back(PoolResource(resource, content_id)); 170 unused_resources_.push_back(PoolResource(resource, content_id));
157 } 171 }
158 172
159 } // namespace cc 173 } // namespace cc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698