cc: Fix the format of GpuMemoryBuffer for SurfaceTexture

content/browser/renderer_host/render_process_host_impl.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Represents the browser side of the browser <--> renderer communication
 // channel. There will be one RenderProcessHost per renderer process.
 
 #include "content/browser/renderer_host/render_process_host_impl.h"
 
 #include <algorithm>
@@ skipping 1128 matching lines @@
       switches::kContentImageTextureTarget,
       base::UintToString(
           // TODO(reveman): We currently assume that the compositor will use
           // BGRA_8888 if it's able to, and RGBA_8888 otherwise. Since we don't
           // know what it will use we hardcode BGRA_8888 here for now. We should
           // instead move decisions about GpuMemoryBuffer format to the browser
           // embedder so we know it here, and pass that decision to the
           // compositor for each usage.
           // crbug.com/490362
           BrowserGpuMemoryBufferManager::GetImageTextureTarget(
+#if defined(OS_ANDROID)
+              gfx::GpuMemoryBuffer::RGBA_8888,
+#else

[reveman, 2015/07/23 07:48:39]

Let's get this fixed properly instead. The problem is that we're trying to
determine what target to use here without knowing the format that the compositor
will use. It's hard to know the format here as it depends on available
extensions.

I think the best solution is to let the compositor know what the target is for
each format. This way the compositor can decide what format it wants to use
without having to worry about the target being wrong.

Let's change the value of switches::kContentImageTextureTarget into a list of
ints. Each int will be the target to use for a supported GMB format. Something
similar to this:

https://code.google.com/p/chromium/codesearch#chromium/src/gpu/config/gpu_uti...

               gfx::GpuMemoryBuffer::BGRA_8888,
+#endif
               // TODO(danakj): When one-copy supports partial update, change
               // this usage to PERSISTENT_MAP for one-copy.
               gfx::GpuMemoryBuffer::MAP)));
 
   command_line->AppendSwitchASCII(
       switches::kVideoImageTextureTarget,
       base::UintToString(BrowserGpuMemoryBufferManager::GetImageTextureTarget(
           gfx::GpuMemoryBuffer::R_8, gfx::GpuMemoryBuffer::MAP)));
 
   // Appending disable-gpu-feature switches due to software rendering list.
@@ skipping 1350 matching lines @@
 void RenderProcessHostImpl::GetAudioOutputControllers(
     const GetAudioOutputControllersCallback& callback) const {
   audio_renderer_host()->GetOutputControllers(callback);
 }
 
 BluetoothDispatcherHost* RenderProcessHostImpl::GetBluetoothDispatcherHost() {
   return bluetooth_dispatcher_host_.get();
 }
 
 }  // namespace content