components/BUILD.gn - Issue 1251633002: Add BubbleManager to manage bubbles and ChromeBubbleManager for events.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/BUILD.gn

Issue 1251633002: Add BubbleManager to manage bubbles and ChromeBubbleManager for events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: gn nit Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/BUILD.gn

diff --git a/components/BUILD.gn b/components/BUILD.gn

index 7d2729b86de3e93202964fb0355f64ed2f6604b9..071b6aaac7b3151f665b25dcbd0c914c405d2e74 100644

--- a/components/BUILD.gn

+++ b/components/BUILD.gn

@@ -23,6 +23,7 @@ group("all_components") {

"//components/bookmarks/common",

"//components/bookmarks/managed",

"//components/bookmarks/test",

+ "//components/bubble",

"//components/captive_portal",

"//components/cdm/browser",

"//components/cdm/common",

@@ -303,6 +304,7 @@ test("components_unittests") {

"//components/autofill/core/common:unit_tests",

"//components/bookmarks/browser:unit_tests",

"//components/bookmarks/managed:unit_tests",

+ "//components/bubble:unit_tests",

"//components/captive_portal:unit_tests",

"//components/cloud_devices/common:unit_tests",

"//components/component_updater:unit_tests",

« no previous file with comments | « chrome/chrome_browser_ui.gypi ('k') | components/OWNERS » ('j') | no next file with comments »