Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Unified Diff: chrome/browser/ui/browser.cc

Issue 1251633002: Add BubbleManager to manage bubbles and ChromeBubbleManager for events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: TESTS! Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser.cc
diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc
index befe5b85037b929614fa0d59510a954408011b3d..f8569339df03eec200391caf094fe1b7688be009 100644
--- a/chrome/browser/ui/browser.cc
+++ b/chrome/browser/ui/browser.cc
@@ -549,6 +549,12 @@ Browser::~Browser() {
///////////////////////////////////////////////////////////////////////////////
// Getters & Setters
+ChromeBubbleManager* Browser::GetBubbleManager() {
+ if (!bubble_manager_)
+ bubble_manager_.reset(new ChromeBubbleManager);
+ return bubble_manager_.get();
+}
+
FindBarController* Browser::GetFindBarController() {
if (!find_bar_controller_.get()) {
FindBar* find_bar = window_->CreateFindBar();
@@ -809,6 +815,8 @@ void Browser::WindowFullscreenStateChanged() {
->WindowFullscreenStateChanged();
command_controller_->FullscreenStateChanged();
UpdateBookmarkBarState(BOOKMARK_BAR_STATE_CHANGE_TOGGLE_FULLSCREEN);
+
+ GetBubbleManager()->WindowFullscreenStateChanged();
}
///////////////////////////////////////////////////////////////////////////////
@@ -990,6 +998,8 @@ void Browser::TabDetachedAt(WebContents* contents, int index) {
}
TabDetachedAtImpl(contents, index, DETACH_TYPE_DETACH);
+
+ GetBubbleManager()->TabDetached();
}
void Browser::TabDeactivated(WebContents* contents) {
@@ -1003,6 +1013,8 @@ void Browser::TabDeactivated(WebContents* contents) {
if (instant_controller_)
instant_controller_->TabDeactivated(contents);
+
+ GetBubbleManager()->TabDeactivated();
}
void Browser::ActiveTabChanged(WebContents* old_contents,

Powered by Google App Engine
This is Rietveld 408576698