Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: components/bubble/bubble_controller.h

Issue 1251633002: Add BubbleManager to manage bubbles and ChromeBubbleManager for events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Kill views_bubble_controller Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/bubble/bubble_controller.h
diff --git a/components/bubble/bubble_controller.h b/components/bubble/bubble_controller.h
new file mode 100644
index 0000000000000000000000000000000000000000..262184b8c979d0489fccad95754292fadff5c1d0
--- /dev/null
+++ b/components/bubble/bubble_controller.h
@@ -0,0 +1,50 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_BUBBLE_BUBBLE_CONTROLLER_H__
+#define COMPONENTS_BUBBLE_BUBBLE_CONTROLLER_H__
+
+#include "base/callback.h"
+
+class BubbleDelegate;
+class BubbleManager;
+
+enum BubbleCloseReason {
please use gerrit instead 2015/07/22 23:56:09 Add comment that this is for manager metrics.
+ // Bubble was closed without any user interaction.
+ BUBBLE_CLOSE_IGNORE = 0,
+
+ // User did not interact with the bubble, but changed tab.
+ BUBBLE_CLOSE_TABSWITCH,
+
+ // User dismissed the bubble. (ESC, close, etc)
+ BUBBLE_CLOSE_CLOSE,
+
+ // User selected the "Allow" option in a bubble.
+ BUBBLE_CLOSE_ALLOW,
+
+ // User selected the "Deny" option in a bubble.
+ BUBBLE_CLOSE_DENY,
+};
+
+class BubbleController {
+ public:
+ BubbleController(BubbleManager* manager, BubbleDelegate* delegate);
+ virtual ~BubbleController();
+
+ virtual void Show();
+ virtual void Hide(BubbleCloseReason reason);
+
+ virtual void UpdatePosition();
+
+ bool IsOwnerOf(BubbleDelegate* delegate) { return delegate == delegate_; }
+
+ private:
+ // Weak.
+ BubbleManager* manager_;
+
+ // Weak.
+ BubbleDelegate* delegate_;
+};
+
+#endif // COMPONENTS_BUBBLE_BUBBLE_CONTROLLER_H__

Powered by Google App Engine
This is Rietveld 408576698