Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller_private.mm

Issue 1251633002: Add BubbleManager to manage bubbles and ChromeBubbleManager for events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Mac Changes to test trybots Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/browser_window_controller_private.mm
diff --git a/chrome/browser/ui/cocoa/browser_window_controller_private.mm b/chrome/browser/ui/cocoa/browser_window_controller_private.mm
index 4d97af49fa0a82b810515aae8efafdf04b0c7937..eb6ee5f003f35590f97630a0fc8dd911b71fa035 100644
--- a/chrome/browser/ui/cocoa/browser_window_controller_private.mm
+++ b/chrome/browser/ui/cocoa/browser_window_controller_private.mm
@@ -235,6 +235,8 @@ willPositionSheet:(NSWindow*)sheet
PermissionBubbleManager* manager = [self permissionBubbleManager];
if (manager)
manager->UpdateAnchorPosition();
+
+ browser_->bubble_manager()->UpdateAllBubbleAnchors();
}
- (void)applyTabStripLayout:(const chrome::TabStripLayout&)layout {
@@ -396,6 +398,8 @@ willPositionSheet:(NSWindow*)sheet
if (statusBubble_)
statusBubble_->SwitchParentWindow(destWindow);
+ browser_->bubble_manager()->UpdateAllBubbleAnchors();
+
// Updates the bubble position.
PermissionBubbleManager* manager = [self permissionBubbleManager];
if (manager)

Powered by Google App Engine
This is Rietveld 408576698