chrome/browser/BUILD.gn - Issue 1251633002: Add BubbleManager to manage bubbles and ChromeBubbleManager for events.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/BUILD.gn

Issue 1251633002: Add BubbleManager to manage bubbles and ChromeBubbleManager for events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Apply Feedback Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/BUILD.gn

diff --git a/chrome/browser/BUILD.gn b/chrome/browser/BUILD.gn

index e8a6f1f6ea89b41e0a14f2ab286ab03bd3ed4412..3fcdac92f28b37e5c69f0c969a941ab3e339794e 100644

--- a/chrome/browser/BUILD.gn

+++ b/chrome/browser/BUILD.gn

@@ -256,6 +256,7 @@ source_set("browser") {

"//components/app_modal",

"//components/autofill/content/browser",

"//components/browsing_data",

+ "//components/bubble",

msw 2015/08/13 03:37:20 This doesn't appear to be necessary (at least not

hcarmona 2015/08/15 02:03:18 Acknowledged.

"//components/data_reduction_proxy/content/browser",

"//components/devtools_discovery",

"//components/devtools_http_handler",

« no previous file with comments | « no previous file | chrome/browser/DEPS » ('j') | chrome/browser/DEPS » ('J')