chrome/chrome_browser_ui.gypi - Issue 1251633002: Add BubbleManager to manage bubbles and ChromeBubbleManager for events.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_browser_ui.gypi

Issue 1251633002: Add BubbleManager to manage bubbles and ChromeBubbleManager for events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Partial Feedback Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/chrome_browser_ui.gypi

diff --git a/chrome/chrome_browser_ui.gypi b/chrome/chrome_browser_ui.gypi

index 24f9b8b27a3a28c53fd64185c5f69f5cca0b16e3..d215158995d011ddef2906fac965b655e7833fe7 100644

--- a/chrome/chrome_browser_ui.gypi

+++ b/chrome/chrome_browser_ui.gypi

@@ -284,6 +284,8 @@

'browser/ui/views/platform_keys_certificate_selector_chromeos.cc',

'browser/ui/views/platform_keys_certificate_selector_chromeos.h',

'browser/ui/web_contents_sizer.h',

+ 'browser/ui/website_settings/permission_bubble_delegate.cc',

+ 'browser/ui/website_settings/permission_bubble_delegate.h',

'browser/ui/website_settings/permission_bubble_manager.cc',

'browser/ui/website_settings/permission_bubble_manager.h',

'browser/ui/website_settings/permission_bubble_request.cc',

@@ -1562,6 +1564,10 @@

'browser/ui/browser_view_prefs.h',

'browser/ui/browser_window_state.cc',

'browser/ui/browser_window_state.h',

+ 'browser/ui/chrome_bubble_manager.cc',

+ 'browser/ui/chrome_bubble_manager.h',

+ 'browser/ui/chrome_bubble_manager_factory.cc',

+ 'browser/ui/chrome_bubble_manager_factory.h',

'browser/ui/chrome_pages.cc',

'browser/ui/chrome_pages.h',

'browser/ui/chrome_style.cc',

« chrome/chrome_browser.gypi ('K') | « chrome/chrome_browser.gypi ('k') | components/BUILD.gn » ('j') | components/bubble/bubble_controller.h » ('J')