Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(652)

Unified Diff: chrome/browser/ui/views/website_settings/permissions_bubble_view.h

Issue 1251633002: Add BubbleManager to manage bubbles and ChromeBubbleManager for events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Partial Feedback Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/website_settings/permissions_bubble_view.h
diff --git a/chrome/browser/ui/views/website_settings/permissions_bubble_view.h b/chrome/browser/ui/views/website_settings/permissions_bubble_view.h
index a9d1836c07edb89ff161e81496c7522398ed61c9..c00b45cbc21c69dd815b5d2cf63581668844eb65 100644
--- a/chrome/browser/ui/views/website_settings/permissions_bubble_view.h
+++ b/chrome/browser/ui/views/website_settings/permissions_bubble_view.h
@@ -16,24 +16,23 @@ namespace views {
class View;
}
-class Browser;
class PermissionsBubbleDelegateView;
class PermissionBubbleViewViews : public PermissionBubbleView {
public:
- explicit PermissionBubbleViewViews(Browser* browser);
+ PermissionBubbleViewViews(
+ PermissionBubbleDelegate* delegate, Browser* browser);
~PermissionBubbleViewViews() override;
- // PermissionBubbleView:
- void SetDelegate(Delegate* delegate) override;
- void Show(const std::vector<PermissionBubbleRequest*>& requests,
- const std::vector<bool>& accept_state) override;
- bool CanAcceptRequestUpdate() override;
+ // BubbleUI
+ void Show() override;
void Hide() override;
- bool IsVisible() override;
void UpdateAnchorPosition() override;
- gfx::NativeWindow GetNativeWindow() override;
+ // PermissionBubbleView:
+ bool CanAcceptRequestUpdate() override;
+
+ // Callbacks from UI:
void Closing();
void Toggle(int index, bool value);
void Accept();
@@ -43,8 +42,8 @@ class PermissionBubbleViewViews : public PermissionBubbleView {
views::View* GetAnchorView();
views::BubbleBorder::Arrow GetAnchorArrow();
+ PermissionBubbleDelegate* delegate_;
please use gerrit instead 2015/08/07 23:02:27 // owned by BubbleManager. (the view is owned by
hcarmona 2015/08/11 02:35:45 Done.
Browser* browser_;
- Delegate* delegate_;
PermissionsBubbleDelegateView* bubble_delegate_;
DISALLOW_COPY_AND_ASSIGN(PermissionBubbleViewViews);

Powered by Google App Engine
This is Rietveld 408576698