Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6730)

Unified Diff: chrome/browser/ui/browser.cc

Issue 1251633002: Add BubbleManager to manage bubbles and ChromeBubbleManager for events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Partial Feedback Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser.cc
diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc
index ac738adafae528c8c6d15f2d785af3f18df44531..f7b71f64c82c67bb1710bbf1a7065fe30e53157d 100644
--- a/chrome/browser/ui/browser.cc
+++ b/chrome/browser/ui/browser.cc
@@ -1760,6 +1760,7 @@ void Browser::RegisterProtocolHandler(WebContents* web_contents,
PermissionBubbleManager* bubble_manager =
PermissionBubbleManager::FromWebContents(web_contents);
if (PermissionBubbleManager::Enabled() && bubble_manager) {
+ bubble_manager->SetBrowser(this);
please use gerrit instead 2015/08/07 23:02:26 Hmmm.
hcarmona 2015/08/11 02:35:45 Gone! :D
bubble_manager->AddRequest(
new RegisterProtocolHandlerPermissionRequest(registry, handler,
url, user_gesture));

Powered by Google App Engine
This is Rietveld 408576698