chrome/browser/ui/browser.cc - Issue 1251633002: Add BubbleManager to manage bubbles and ChromeBubbleManager for events.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser.cc

Issue 1251633002: Add BubbleManager to manage bubbles and ChromeBubbleManager for events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Work in Progress Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/browser.h ('k') | chrome/browser/ui/views/bubble/views_bubble_controller.h » ('j') | chrome/browser/ui/views/bubble/views_bubble_controller.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/browser.cc

diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc

index 61a36ff10a0df4b6e8b0c00ee54cee612f29012f..9e3a9ca4fd5deb10250b60592577ae68f1aab519 100644

--- a/chrome/browser/ui/browser.cc

+++ b/chrome/browser/ui/browser.cc

@@ -155,6 +155,8 @@

#include "components/app_modal/javascript_dialog_manager.h"

#include "components/bookmarks/browser/bookmark_model.h"

#include "components/bookmarks/browser/bookmark_utils.h"

+#include "components/bubble/bubble_controller.h"

please use gerrit instead 2015/07/22 00:09:36 Isn't this an implementation detail of the manager

+#include "components/bubble/bubble_manager.h"

#include "components/content_settings/core/browser/host_content_settings_map.h"

#include "components/favicon/content/content_favicon_driver.h"

#include "components/history/core/browser/top_sites.h"

@@ -341,6 +343,8 @@ Browser::Browser(const CreateParams& params)

type_(params.type),

profile_(params.profile),

window_(NULL),

+ bubble_manager_(

+ new BubbleManager(base::Bind(&BubbleController::Create))),

please use gerrit instead 2015/07/22 00:09:36 Why parameterize creation? I think we can use Bubb

tab_strip_model_delegate_(new chrome::BrowserTabStripModelDelegate(this)),

tab_strip_model_(

new TabStripModel(tab_strip_model_delegate_.get(), params.profile)),