Add BubbleManager to manage bubbles and ChromeBubbleManager for events.

chrome/browser/ui/browser.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/browser.h"
 
 #if defined(OS_WIN)
 #include <windows.h>
 #include <shellapi.h>
 #endif  // defined(OS_WIN)
@@ skipping 453 matching lines @@
 Browser::~Browser() {
   // Stop observing notifications before continuing with destruction. Profile
   // destruction will unload extensions and reentrant calls to Browser:: should
   // be avoided while it is being torn down.
   registrar_.RemoveAll();
   extension_registry_observer_.RemoveAll();
 
   // The tab strip should not have any tabs at this point.
   DCHECK(tab_strip_model_->empty());
   tab_strip_model_->RemoveObserver(this);
+  if (bubble_manager_)
+    tab_strip_model_->RemoveObserver(bubble_manager_.get());

[msw, 2015/08/26 01:42:35]

Make the ChromeBubbleManager dtor remove itself as an observer and just
unconditionally call |bubble_manager_.reset()| here (or soon; ie. before
tab_strip_model_ is destroyed).

[hcarmona, 2015/08/26 17:25:58]

Done.

 
   // Destroy the BrowserCommandController before removing the browser, so that
   // it doesn't act on any notifications that are sent as a result of removing
   // the browser.
   command_controller_.reset();
   BrowserList::RemoveBrowser(this);
 
   SessionService* session_service =
       SessionServiceFactory::GetForProfile(profile_);
   if (session_service)
@@ skipping 58 matching lines @@
   if (OkToCloseWithInProgressDownloads(&num_downloads) ==
           DOWNLOAD_CLOSE_BROWSER_SHUTDOWN &&
       !browser_defaults::kBrowserAliveWithNoWindows) {
     DownloadService::CancelAllDownloads();
   }
 }
 
 ///////////////////////////////////////////////////////////////////////////////
 // Getters & Setters
 
+ChromeBubbleManager* Browser::GetBubbleManager() {
+  if (!bubble_manager_) {
+    bubble_manager_.reset(new ChromeBubbleManager);
+    tab_strip_model_->AddObserver(bubble_manager_.get());

[msw, 2015/08/26 01:42:35]

Do this in the ChromeBubbleManager ctor; pass it |tab_strip_model_| or |this|.

[hcarmona, 2015/08/26 17:25:58]

Done.

+  }
+  return bubble_manager_.get();
+}
+
 FindBarController* Browser::GetFindBarController() {
   if (!find_bar_controller_.get()) {
     FindBar* find_bar = window_->CreateFindBar();
     find_bar_controller_.reset(new FindBarController(find_bar));
     find_bar->SetFindBarController(find_bar_controller_.get());
     find_bar_controller_->ChangeWebContents(
         tab_strip_model_->GetActiveWebContents());
     find_bar_controller_->find_bar()->MoveWindowIfNecessary(gfx::Rect());
   }
   return find_bar_controller_.get();
@@ skipping 240 matching lines @@
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // Browser, Tab adding/showing functions:
 
 void Browser::WindowFullscreenStateChanged() {
   exclusive_access_manager_->fullscreen_controller()
       ->WindowFullscreenStateChanged();
   command_controller_->FullscreenStateChanged();
   UpdateBookmarkBarState(BOOKMARK_BAR_STATE_CHANGE_TOGGLE_FULLSCREEN);
+
+  GetBubbleManager()->WindowFullscreenStateChanged();

[msw, 2015/08/26 01:42:35]

Make this conditional on the existence of a manager, don't create one here.

[hcarmona, 2015/08/26 17:25:58]

Done.

 }
 
 ///////////////////////////////////////////////////////////////////////////////
 // Browser, Assorted browser commands:
 
 void Browser::ToggleFullscreenModeWithExtension(const GURL& extension_url) {
   exclusive_access_manager_->fullscreen_controller()
       ->ToggleBrowserFullscreenModeWithExtension(extension_url);
 }
 
@@ skipping 1834 matching lines @@
   if (contents && !allow_js_access) {
     contents->web_contents()->GetController().LoadURL(
         target_url,
         content::Referrer(),
         ui::PAGE_TRANSITION_LINK,
         std::string());  // No extra headers.
   }
 
   return contents != NULL;
 }