Add BubbleManager to manage bubbles and ChromeBubbleManager for events.

components/bubble/bubble_delegate.h

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_BUBBLE_BUBBLE_DELEGATE_H_
+#define COMPONENTS_BUBBLE_BUBBLE_DELEGATE_H_
+
+#include "base/memory/scoped_ptr.h"
+
+class BubbleUI;
+
+// List of reasons why a bubble might close. These correspond to various events
+// from the UI. Not all platforms will receive all events.
+enum BubbleCloseReason {

[msw, 2015/08/21 01:48:30]

nit: maybe this belongs in its own file (that would also alleviate the need to
include bubble_delegate.h in so many other headers)

[hcarmona, 2015/08/25 02:13:36]

Done.

+  // Bubble was closed without any user interaction.
+  BUBBLE_CLOSE_FOCUS_LOST,
+
+  // User did not interact with the bubble, but changed tab.
+  BUBBLE_CLOSE_TABSWITCHED,
+
+  // User did not interact with the bubble, but detached the tab.
+  BUBBLE_CLOSE_TABDETACHED,
+
+  // User dismissed the bubble. (ESC, close, etc.)
+  BUBBLE_CLOSE_USER_DISMISSED,
+
+  // There has been a navigation event. (Link, URL typed, refresh, etc.)
+  BUBBLE_CLOSE_NAVIGATED,
+
+  // Window has entered fullscreen mode. Will also be called for immersive

[msw, 2015/08/21 01:48:30]

nit: The parent window has entered or exited

[hcarmona, 2015/08/25 02:13:37]

Done.

+  // fullscreen.
+  BUBBLE_CLOSE_FULLSCREEN_TOGGLED,

[msw, 2015/08/21 01:48:30]

I wonder if this should be used for other anchor window bounds changes. If a
bubble isn't closing for loss of focus, then the parent/anchor window bounds can
be manipulated (and the bubble anchor may need updating). Views bubbles should
already handle those anchor window updates with a WidgetObserver, but we might
want to add a notification for that here (or expand this one to cover broader
anchor window bounds changes). This may not be immediately necessary if we rely
on per-platform behavior, but then that might be worth noting in a comment.

[hcarmona, 2015/08/25 02:13:37]

I'm a bit confused by what exactly this comment means... I don't think that
resizing a window should send a close bubble event. A bubble should
close itself because of a loss of focus at that point, rather than rely
on a window resize event.

[msw, 2015/08/26 01:42:35]

My thought was also that bubbles might need to update their anchoring on parent
window size changes (or maybe close if their anchor has disappeared due to
layout changes). But as I said, views already does the basics here, and it might
not be needed for now.

[hcarmona, 2015/08/26 17:25:57]

Acknowledged.

+
+  // The user selected an affirmative response in the bubble.
+  BUBBLE_CLOSE_ACCEPTED,
+
+  // The user selected a negative response in the bubble.
+  BUBBLE_CLOSE_CANCELED,
+
+  // The bubble WILL be closed regardless of return value for |ShouldClose|.
+  // Ex: The bubble's parent window is being destroyed.
+  BUBBLE_CLOSE_FORCED,
+};
+
+// Inherit from this class to define a bubble. A bubble is a small transient UI
+// surface anchored to a parent window. Most bubbles are dismissed when they
+// lose focus.
+class BubbleDelegate {
+ public:
+  BubbleDelegate() {}

[msw, 2015/08/21 01:48:30]

nit: if you move the dtor definition, you may as well move this too.

[hcarmona, 2015/08/25 02:13:36]

Done.

+  virtual ~BubbleDelegate() {}

[msw, 2015/08/21 01:48:30]

nit: this virtual dtor should be defined in the cc file, i think.

[hcarmona, 2015/08/25 02:13:37]

Done.

+
+  // Called by BubbleController to notify a bubble of an event that the bubble
+  // might want to close on. Return true if the bubble should close for the
+  // specified reason.
+  virtual bool ShouldClose(BubbleCloseReason reason);
+
+  // Called by BubbleController to build the UI that will represent this bubble.
+  // BubbleDelegate should not keep a reference to this newly created UI.
+  virtual scoped_ptr<BubbleUI> BuildBubbleUI() = 0;
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(BubbleDelegate);
+};
+
+#endif  // COMPONENTS_BUBBLE_BUBBLE_DELEGATE_H_