Add BubbleManager to manage bubbles and ChromeBubbleManager for events.

chrome/browser/ui/browser.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/browser.h"
 
 #if defined(OS_WIN)
 #include <windows.h>
 #include <shellapi.h>
 #endif  // defined(OS_WIN)
@@ skipping 791 matching lines @@
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // Browser, Tab adding/showing functions:
 
 void Browser::WindowFullscreenStateChanged() {
   exclusive_access_manager_->fullscreen_controller()
       ->WindowFullscreenStateChanged();
   command_controller_->FullscreenStateChanged();
   UpdateBookmarkBarState(BOOKMARK_BAR_STATE_CHANGE_TOGGLE_FULLSCREEN);
+
+  bubble_manager_.FullscreenToggle();

[msw, 2015/08/18 17:26:18]

nit: name this WindowFullscreenStateChanged for consistency.

[msw, 2015/08/18 17:26:18]

It'd be nice if this didn't have to be hooked directly, but I don't know of a
cross-platform way for BubbleManager to observe gfx::NativeWindow
size/position/fullscreen changes. WidgetObserver would work for views, but not
for Cocoa...

[hcarmona, 2015/08/18 23:08:47]

Acknowledged.

[hcarmona, 2015/08/18 23:08:47]

Done.

 }
 
 ///////////////////////////////////////////////////////////////////////////////
 // Browser, Assorted browser commands:
 
 void Browser::ToggleFullscreenModeWithExtension(const GURL& extension_url) {
   exclusive_access_manager_->fullscreen_controller()
       ->ToggleBrowserFullscreenModeWithExtension(extension_url);
 }
 
@@ skipping 161 matching lines @@
   int old_active_index = tab_strip_model_->active_index();
   if (index < old_active_index && !tab_strip_model_->closing_all()) {
     SessionService* session_service =
         SessionServiceFactory::GetForProfileIfExisting(profile_);
     if (session_service)
       session_service->SetSelectedTabInWindow(session_id(),
                                               old_active_index - 1);
   }
 
   TabDetachedAtImpl(contents, index, DETACH_TYPE_DETACH);
+
+  bubble_manager_.TabDetached();

[msw, 2015/08/18 17:26:18]

Instead of adding logic here, can the ChromeBubbleManager also be a
TabStripModelObserver, like Browser?

[hcarmona, 2015/08/18 23:08:47]

Making it into a TabStipModelObserver seems like overkill just for
TabDetached and TabDeactivated since we still need to forward the
fullscreen event to the bubble manager.

[msw, 2015/08/19 00:18:11]

I don't think it's overkill, especially when it reduces the code you're adding
to browser.cc. Ideally, we wouldn't need any bubble manager logic here, and I'm
sure others would agree that making ChromeBubbleManager a TabStripModelObserver
is a step in the right direction.

[groby-ooo-7-16, 2015/08/19 00:52:01]

+1 on that. browser.cc is currently some catch-all repository. The more we can
remove there, the happier the world is. 

 }
 
 void Browser::TabDeactivated(WebContents* contents) {
   exclusive_access_manager_->OnTabDeactivated(contents);
   search_delegate_->OnTabDeactivated(contents);
   SearchTabHelper::FromWebContents(contents)->OnTabDeactivated();
 
   // Save what the user's currently typing, so it can be restored when we
   // switch back to this tab.
   window_->GetLocationBar()->SaveStateToContents(contents);
 
   if (instant_controller_)
     instant_controller_->TabDeactivated(contents);
+
+  bubble_manager_.TabBlur();

[msw, 2015/08/18 17:26:18]

Ditto, make ChromeBubbleManager a TabStripModelObserver

[hcarmona, 2015/08/18 23:08:47]

Acknowledged.

 }
 
 void Browser::ActiveTabChanged(WebContents* old_contents,
                                WebContents* new_contents,
                                int index,
                                int reason) {
   content::RecordAction(UserMetricsAction("ActiveTabChanged"));
 
   // Update the bookmark state, since the BrowserWindow may query it during
   // OnActiveTabChanged() below.
@@ skipping 64 matching lines @@
                                          base::TimeTicks::Now());
     }
   }
 
   // This needs to be called after notifying SearchDelegate.
   if (instant_controller_)
     instant_controller_->ActiveTabChanged();
 
   autofill::ChromeAutofillClient::FromWebContents(new_contents)->TabActivated();
   SearchTabHelper::FromWebContents(new_contents)->OnTabActivated();
+
+  bubble_manager_.TabFocus();

[msw, 2015/08/18 17:26:18]

Ditto, make ChromeBubbleManager a TabStripModelObserver

[hcarmona, 2015/08/18 23:08:47]

This function's not needed.

 }
 
 void Browser::TabMoved(WebContents* contents,
                        int from_index,
                        int to_index) {
   DCHECK(from_index >= 0 && to_index >= 0);
   // Notify the history service.
   SyncHistoryWithTabs(std::min(from_index, to_index));
 }
 
@@ skipping 1556 matching lines @@
   if (contents && !allow_js_access) {
     contents->web_contents()->GetController().LoadURL(
         target_url,
         content::Referrer(),
         ui::PAGE_TRANSITION_LINK,
         std::string());  // No extra headers.
   }
 
   return contents != NULL;
 }