components/bubble/DEPS - Issue 1251633002: Add BubbleManager to manage bubbles and ChromeBubbleManager for events.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/bubble/DEPS

Issue 1251633002: Add BubbleManager to manage bubbles and ChromeBubbleManager for events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Apply Feedback Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+ui/base/cursor",

3 "+ui/gfx",	2 "+ui/gfx",

	3 "+content/public/browser"
	hcarmona 2015/08/11 02:35:47 Not sure if it's ok to include this... Added to ve Not sure if it's ok to include this... Added to verify that we're in the UI thread. msw 2015/08/13 03:37:21 This seems to happen in other places, and doesn't Show quoted text On 2015/08/11 02:35:47, Hector Carmona wrote: > Not sure if it's ok to include this... Added to verify that we're in > the UI thread. This seems to happen in other places, and doesn't appear to conflict with other new DEPS, so it's potentially okay, but it'd be nice to avoid if possible... Really, shouldn't checking the chrome thread be delegated to ChromeBubbleManager::ShowBubbleUI (and shouldn't it also be checked by ChromeBubbleManager::UpdateBubbleUI, and maybe other similar operations like hide/close?) https://code.google.com/p/chromium/codesearch#search/&q=%22%2Bcontent/public/...
4 ]	4 ]

OLD	NEW

« components/OWNERS ('K') | « components/bubble/BUILD.gn ('k') | components/bubble/OWNERS » ('j') | components/bubble/OWNERS » ('J')