Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(789)

Side by Side Diff: chrome/browser/ui/chrome_bubble_manager.h

Issue 1251633002: Add BubbleManager to manage bubbles and ChromeBubbleManager for events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Apply Feedback Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef CHROME_BROWSER_UI_CHROME_BUBBLE_MANAGER_H_
6 #define CHROME_BROWSER_UI_CHROME_BUBBLE_MANAGER_H_
7
8 #include "components/bubble/bubble_manager.h"
9 #include "components/keyed_service/core/keyed_service.h"
10 #include "content/public/browser/navigation_details.h"
11
12 namespace content {
13 class WebContents;
14 } // content
msw 2015/08/13 03:37:21 nit: "namespace content"
hcarmona 2015/08/15 02:03:18 Acknowledged.
15
16 class ChromeBubbleManager : public BubbleManager,
msw 2015/08/13 03:37:21 Should this also handle browser window activation/
groby-ooo-7-16 2015/08/13 18:44:38 None of these affect bubbles. (And hopefully never
msw 2015/08/13 19:18:57 If the bubbles don't close on deactivate, they pot
17 public KeyedService,
18 public base::SupportsWeakPtr<ChromeBubbleManager> {
19 public:
20 ChromeBubbleManager();
21 ~ChromeBubbleManager() override;
22
23 void FullscreenToggle(content::WebContents* context);
24 void TabBlur(content::WebContents* context);
25 void TabFocus(content::WebContents* context);
26 void TabDetached(content::WebContents* context);
27 void NavigationEntryCommitted(content::WebContents* context,
28 const content::LoadCommittedDetails& details);
29 void WebContentsDestroyed(content::WebContents* context);
30
31 private:
32 DISALLOW_COPY_AND_ASSIGN(ChromeBubbleManager);
33 };
34
35 #endif // CHROME_BROWSER_UI_CHROME_BUBBLE_MANAGER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698