chrome/browser/ui/views/bubble/views_bubble_controller.cc - Issue 1251633002: Add BubbleManager to manage bubbles and ChromeBubbleManager for events.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/views/bubble/views_bubble_controller.cc

Issue 1251633002: Add BubbleManager to manage bubbles and ChromeBubbleManager for events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Work in Progress Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/ui/browser.cc ('K') | « chrome/browser/ui/views/bubble/views_bubble_controller.h ('k') | chrome/browser/ui/views/website_settings/permissions_bubble_view.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "chrome/browser/ui/views/bubble/views_bubble_controller.h"

	6

	7 ViewsBubbleController::ViewsBubbleController(BubbleManager* manager,

	8 BubbleDelegate* delegate)

	9 : BubbleController(manager, delegate) {}
	please use gerrit instead 2015/07/22 00:09:36 Why have a separate class for ViewsBubbleControlle Why have a separate class for ViewsBubbleController that has no differences from the base class BubbleController? We usually don't add code that we will need in the future, because plans might change in unexpected ways.
	10

	11 // Static.

	12 scoped_ptr<BubbleController> BubbleController::Create(

	13 BubbleManager* manager,

	14 BubbleDelegate* delegate) {

	15 return make_scoped_ptr(new ViewsBubbleController(manager, delegate));

	16 }

OLD	NEW