Issue 125163004: Clean up DriveAppRegistry (part 1 of 2).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 125163004: Clean up DriveAppRegistry (part 1 of 2). (Closed)

Created:
6 years, 11 months ago by kinaba

Modified:
6 years, 11 months ago

Reviewers:
hashimoto

CC:
chromium-reviews, tfarina, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Clean up DriveAppRegistry (part 1 of 2). - Removed unused fields from DriveAppInfo. It is easy to recover them later when needed. - A bit of rewriting for FindPreferredIcon. BUG=332014 R=hashimoto@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243465

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -102 lines)			Patch
M	chrome/browser/chromeos/drive/drive_app_registry.h	View		3 chunks	+0 lines, -12 lines	0 comments	Download
M	chrome/browser/chromeos/drive/drive_app_registry.cc	View	1	8 chunks	+16 lines, -74 lines	0 comments	Download
M	chrome/browser/chromeos/drive/drive_app_registry_unittest.cc	View		2 chunks	+6 lines, -16 lines	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/125163004/40001

6 years, 11 months ago (2014-01-07 23:05:14 UTC) #4

kinaba

6 years, 11 months ago (2014-01-08 01:41:48 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r243465 (presubmit successful).