Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 1251603004: [es6] Fix and clean up recognition of simple parameter lists (Closed)

Created:
5 years, 5 months ago by rossberg
Modified:
5 years, 5 months ago
CC:
v8-dev, Dan Ehrenberg
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] Fix and clean up recognition of simple parameter lists Gets rid of IsSimpleParameterList predicate. R=mstarzinger@chromium.org, caitpotter88@gmail.com BUG= Committed: https://crrev.com/a10e877c3e6ffef3b15e433d888a719619116a42 Cr-Commit-Position: refs/heads/master@{#29815}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -15 lines) Patch
M src/parser.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/parser.cc View 1 5 chunks +10 lines, -13 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
rossberg
5 years, 5 months ago (2015-07-23 10:57:51 UTC) #1
Michael Starzinger
LGTM.
5 years, 5 months ago (2015-07-23 11:15:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1251603004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1251603004/20001
5 years, 5 months ago (2015-07-23 11:58:37 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/7991)
5 years, 5 months ago (2015-07-23 12:10:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1251603004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1251603004/20001
5 years, 5 months ago (2015-07-23 14:03:46 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-23 14:29:04 UTC) #10
commit-bot: I haz the power
5 years, 5 months ago (2015-07-23 14:29:17 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a10e877c3e6ffef3b15e433d888a719619116a42
Cr-Commit-Position: refs/heads/master@{#29815}

Powered by Google App Engine
This is Rietveld 408576698