Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1251593009: convert a bunch of DCHECKs to STATIC_ASSERT (Closed)

Created:
5 years, 5 months ago by Mostyn Bramley-Moore
Modified:
5 years, 5 months ago
Reviewers:
rmcilroy
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

convert a bunch of DCHECKs to STATIC_ASSERT Committed: https://crrev.com/ff5444199a2a2cf1bc1ce68ce12a458beb90a6f5 Cr-Commit-Position: refs/heads/master@{#29825}

Patch Set 1 #

Patch Set 2 : and another #

Patch Set 3 : add missing include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -78 lines) Patch
M src/arm/code-stubs-arm.cc View 4 chunks +11 lines, -11 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M src/elements-kind.h View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M src/ia32/code-stubs-ia32.cc View 4 chunks +11 lines, -11 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 4 chunks +10 lines, -10 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 4 chunks +11 lines, -11 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 4 chunks +10 lines, -10 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 4 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Mostyn Bramley-Moore
@rmcilroy: PTAL. The ppc and x87 targets don't seem to build for me on master ...
5 years, 5 months ago (2015-07-22 19:37:53 UTC) #2
rmcilroy
On 2015/07/22 19:37:53, Mostyn Bramley-Moore wrote: > @rmcilroy: PTAL. > > The ppc and x87 ...
5 years, 5 months ago (2015-07-23 09:38:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1251593009/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1251593009/20001
5 years, 5 months ago (2015-07-23 22:40:19 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_android_arm_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/builds/6186) v8_win64_rel on tryserver.v8 (JOB_FAILED, ...
5 years, 5 months ago (2015-07-23 22:43:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1251593009/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1251593009/40001
5 years, 5 months ago (2015-07-23 22:57:30 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 5 months ago (2015-07-23 23:34:59 UTC) #11
commit-bot: I haz the power
5 years, 5 months ago (2015-07-23 23:35:25 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ff5444199a2a2cf1bc1ce68ce12a458beb90a6f5
Cr-Commit-Position: refs/heads/master@{#29825}

Powered by Google App Engine
This is Rietveld 408576698