Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(890)

Issue 1251573006: Cleanup: Enable 125DSFForUIScaling on by default (Closed)

Created:
5 years, 5 months ago by oshima
Modified:
5 years, 5 months ago
Reviewers:
Jun Mukai
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Enable 125DSFForUIScaling on by default * Fix typo * Introduced Scoped125DSFForUIScaling to temporarily disable it for testing. * Make sure id isn't invalid when checking if it's internal. This problem exists only in unit tests, not in production. BUG=None Committed: https://crrev.com/6cd1ca5ee1404407c70f1941a18f0ec0a83431b7 Cr-Commit-Position: refs/heads/master@{#339822}

Patch Set 1 : #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -40 lines) Patch
M ash/display/display_info.h View 2 chunks +6 lines, -6 lines 0 comments Download
M ash/display/display_info.cc View 1 2 9 chunks +21 lines, -17 lines 0 comments Download
M ash/display/display_info_unittest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ash/display/display_manager.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ash/display/display_manager_unittest.cc View 6 chunks +3 lines, -9 lines 0 comments Download
M ash/test/display_manager_test_api.h View 1 chunk +9 lines, -0 lines 0 comments Download
M ash/test/display_manager_test_api.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1251573006/40001
5 years, 5 months ago (2015-07-22 00:35:34 UTC) #5
oshima
5 years, 5 months ago (2015-07-22 00:42:57 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1251573006/60001
5 years, 5 months ago (2015-07-22 00:44:12 UTC) #8
Jun Mukai
https://codereview.chromium.org/1251573006/diff/60001/ash/display/display_info.cc File ash/display/display_info.cc (right): https://codereview.chromium.org/1251573006/diff/60001/ash/display/display_info.cc#newcode94 ash/display/display_info.cc:94: if (is_internal && device_scale_factor == 1.25f) doesn't use_125_dsf_for_ui_scaling affect ...
5 years, 5 months ago (2015-07-22 00:51:11 UTC) #9
oshima
https://codereview.chromium.org/1251573006/diff/60001/ash/display/display_info.cc File ash/display/display_info.cc (right): https://codereview.chromium.org/1251573006/diff/60001/ash/display/display_info.cc#newcode94 ash/display/display_info.cc:94: if (is_internal && device_scale_factor == 1.25f) On 2015/07/22 00:51:11, ...
5 years, 5 months ago (2015-07-22 01:09:24 UTC) #10
Jun Mukai
lgtm
5 years, 5 months ago (2015-07-22 01:15:56 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1251573006/80001
5 years, 5 months ago (2015-07-22 01:37:50 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:80001)
5 years, 5 months ago (2015-07-22 02:42:55 UTC) #14
commit-bot: I haz the power
5 years, 5 months ago (2015-07-22 02:43:31 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6cd1ca5ee1404407c70f1941a18f0ec0a83431b7
Cr-Commit-Position: refs/heads/master@{#339822}

Powered by Google App Engine
This is Rietveld 408576698