Issue 1251553002: Try to unbreak mini_installer build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1251553002: Try to unbreak mini_installer build. (Closed)

Created:
5 years, 5 months ago by Nico

Modified:
5 years, 5 months ago

Reviewers:
robertshield

CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Try to unbreak mini_installer build. It looks like it doesn't understand static_assert? Use the COMPILE_ASSERT from before https://codereview.chromium.org/1248483002/ if __cplusplus is too low. BUG=512396 TBR=robertshield Committed: https://chromium.googlesource.com/chromium/src/+/b16c31228d83988c0f86e8c4ff191f867c0a9b9e

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -1 line)			Patch
	M	chrome/installer/mini_installer/mini_string.h	View		1 chunk	+8 lines, -1 line	0 comments	Download

Total messages: 4 (1 generated)

Nico

5 years, 5 months ago (2015-07-21 17:51:57 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
b16c31228d83988c0f86e8c4ff191f867c0a9b9e (presubmit successful).